Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon/core/BUILD.gn

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)
Patch Set: Revert requiring non-null service for FaviconHandler. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/favicon/content/content_favicon_driver_unittest.cc ('K') | « components/favicon/content/content_favicon_driver_unittest.cc ('k') | components/favicon/core/favicon_handler_unittest.cc » ('j') | components/favicon/core/favicon_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/BUILD.gn
diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn
index 41aa876b07bf413bf2be15b556cb58f935a6efda..533a36d9bdf3380541acfa5063e5573386d25747 100644
--- a/components/favicon/core/BUILD.gn
+++ b/components/favicon/core/BUILD.gn
@@ -16,6 +16,8 @@ static_library("core") {
"favicon_handler.h",
"favicon_service.cc",
"favicon_service.h",
+ "favicon_service_impl.cc",
+ "favicon_service_impl.h",
"favicon_url.cc",
"favicon_url.h",
"favicon_util.cc",
@@ -57,8 +59,10 @@ source_set("unit_tests") {
deps = [
":core",
"//base",
+ "//components/favicon/core/test:test_support",
"//components/favicon_base",
"//skia",
+ "//testing/gmock",
"//testing/gtest",
"//ui/base",
"//ui/gfx",
« components/favicon/content/content_favicon_driver_unittest.cc ('K') | « components/favicon/content/content_favicon_driver_unittest.cc ('k') | components/favicon/core/favicon_handler_unittest.cc » ('j') | components/favicon/core/favicon_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698