Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: components/favicon/core/BUILD.gn

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)
Patch Set: Revert requiring non-null service for FaviconHandler. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("core") { 5 static_library("core") {
6 sources = [ 6 sources = [
7 "fallback_url_util.cc", 7 "fallback_url_util.cc",
8 "fallback_url_util.h", 8 "fallback_url_util.h",
9 "favicon_client.h", 9 "favicon_client.h",
10 "favicon_driver.cc", 10 "favicon_driver.cc",
11 "favicon_driver.h", 11 "favicon_driver.h",
12 "favicon_driver_impl.cc", 12 "favicon_driver_impl.cc",
13 "favicon_driver_impl.h", 13 "favicon_driver_impl.h",
14 "favicon_driver_observer.h", 14 "favicon_driver_observer.h",
15 "favicon_handler.cc", 15 "favicon_handler.cc",
16 "favicon_handler.h", 16 "favicon_handler.h",
17 "favicon_service.cc", 17 "favicon_service.cc",
18 "favicon_service.h", 18 "favicon_service.h",
19 "favicon_service_impl.cc",
20 "favicon_service_impl.h",
19 "favicon_url.cc", 21 "favicon_url.cc",
20 "favicon_url.h", 22 "favicon_url.h",
21 "favicon_util.cc", 23 "favicon_util.cc",
22 "favicon_util.h", 24 "favicon_util.h",
23 "large_icon_service.cc", 25 "large_icon_service.cc",
24 "large_icon_service.h", 26 "large_icon_service.h",
25 ] 27 ]
26 28
27 deps = [ 29 deps = [
28 "//base", 30 "//base",
(...skipping 21 matching lines...) Expand all
50 testonly = true 52 testonly = true
51 sources = [ 53 sources = [
52 "fallback_url_util_unittest.cc", 54 "fallback_url_util_unittest.cc",
53 "favicon_handler_unittest.cc", 55 "favicon_handler_unittest.cc",
54 "large_icon_service_unittest.cc", 56 "large_icon_service_unittest.cc",
55 ] 57 ]
56 58
57 deps = [ 59 deps = [
58 ":core", 60 ":core",
59 "//base", 61 "//base",
62 "//components/favicon/core/test:test_support",
60 "//components/favicon_base", 63 "//components/favicon_base",
61 "//skia", 64 "//skia",
65 "//testing/gmock",
62 "//testing/gtest", 66 "//testing/gtest",
63 "//ui/base", 67 "//ui/base",
64 "//ui/gfx", 68 "//ui/gfx",
65 "//ui/gfx:test_support", 69 "//ui/gfx:test_support",
66 "//url", 70 "//url",
67 ] 71 ]
68 } 72 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698