Issue 269843002: Use m_targetElementInstance in fewer places

Issue 269843002: Use m_targetElementInstance in fewer places (Closed)

Created:
6 years, 7 months ago by rwlbuis

Modified:
6 years, 7 months ago

Reviewers:
pdr.

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use m_targetElementInstance in fewer places Use m_targetElementInstance in fewer places since SVGElementInstance is scheduled for removal. BUG=313438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173273

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix remaining issues #

Patch Set 3 : Fix compile error in debug #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -32 lines)			Patch
	M	Source/core/svg/SVGUseElement.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	Source/core/svg/SVGUseElement.cpp	View	1 2	7 chunks	+27 lines, -30 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

PTAL. I am a bit concerned about the cost of userAgentShadowRoot(), so I stopped at ...

6 years, 7 months ago (2014-05-03 17:47:11 UTC) #1

pdr.

LGTM if the bots are happy. https://codereview.chromium.org/269843002/diff/1/Source/core/svg/SVGUseElement.cpp File Source/core/svg/SVGUseElement.cpp (right): https://codereview.chromium.org/269843002/diff/1/Source/core/svg/SVGUseElement.cpp#newcode484 Source/core/svg/SVGUseElement.cpp:484: buildShadowTree(target, m_targetElementInstance.get()); Could ...

6 years, 7 months ago (2014-05-03 21:02:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/269843002/20001

6 years, 7 months ago (2014-05-03 21:50:27 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 7 months ago (2014-05-03 22:23:51 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink

6 years, 7 months ago (2014-05-03 22:23:52 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/269843002/40001

6 years, 7 months ago (2014-05-03 23:10:16 UTC) #8

Message was sent while issue was closed.

Change committed as 173273

Expand Messages | Collapse Messages