Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: ios/web/public/web_state/ui/crw_web_delegate.h

Issue 2698413004: Implemented WebStateObserver::DidFinishNavigation(NavigationHandle*). (Closed)
Patch Set: Self review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/web_state/ui/crw_web_delegate.h
diff --git a/ios/web/public/web_state/ui/crw_web_delegate.h b/ios/web/public/web_state/ui/crw_web_delegate.h
index d64f80440d08e8600d37124106b85985afba12c2..234da9deec63257bec4b5b83de7919c2a8b02e25 100644
--- a/ios/web/public/web_state/ui/crw_web_delegate.h
+++ b/ios/web/public/web_state/ui/crw_web_delegate.h
@@ -67,16 +67,14 @@ struct Referrer;
// Called when the page URL has changed. Phase will be PAGE_LOADING. Can be
// followed by webDidFinishWithURL or webWillStartLoadingURL.
// |updateHistory| is YES if the URL should be added to the history DB.
-// TODO(stuartmorgan): Remove or rename the history param; the history DB
-// isn't a web concept, so this shoud be expressed differently.
+// TODO(crbug.com/692331): Remove this method and use |DidFinishNavigation|.
- (void)webDidStartLoadingURL:(const GURL&)url
shouldUpdateHistory:(BOOL)updateHistory;
// Called when the page load was cancelled by page activity (before a success /
// failure state is known). Phase will be PAGE_LOADED.
- (void)webLoadCancelled:(const GURL&)url;
// Called when a page updates its history stack using pushState or replaceState.
-// TODO(stuartmorgan): Generalize this to cover any change of URL without page
-// document change.
+// TODO(crbug.com/692331): Remove this method and use |DidFinishNavigation|.
- (void)webDidUpdateHistoryStateWithPageURL:(const GURL&)pageUrl;
// Called when a placeholder image should be displayed instead of the WebView.
- (void)webController:(CRWWebController*)webController
@@ -100,6 +98,7 @@ struct Referrer;
(const web::NavigationManager::WebLoadParams&)params
wasInitialNavigation:(BOOL)initialNavigation;
// Called from finishHistoryNavigationFromEntry.
+// TODO(crbug.com/692331): Remove this method and use |DidFinishNavigation|.
- (void)webWillFinishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry;
// ---------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698