content/browser/frame_host/navigation_handle_impl.cc - Issue 2698393002: Allow asynchronous deferral in NavigationSimulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2698393002: Allow asynchronous deferral in NavigationSimulator (Closed)

Patch Set: engedy/clamy review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index 68d8d0557c144eea693bdb562659ba38f5cbf53a..8a45b4791c7b72d7167fdccbecb6714a07f4c944 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -880,6 +880,11 @@ void NavigationHandleImpl::RunCompleteCallback(

ThrottleChecksFinishedCallback callback = complete_callback_;

complete_callback_.Reset();

+ if (!complete_callback_for_testing_.is_null()) {

+ complete_callback_for_testing_.Run(result);

+ complete_callback_for_testing_.Reset();

+ }

if (!callback.is_null())

callback.Run(result);