Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7804)

Unified Diff: chrome/browser/ui/views/payments/editor_view_controller.cc

Issue 2698353002: [Payments] Add the "Cards accepted" row at the top of CC editor. (Closed)
Patch Set: Initial Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/editor_view_controller.cc b/chrome/browser/ui/views/payments/editor_view_controller.cc
index 239a04fe012e3b4707ff3f0435db90b5a29b1363..84c0bb7f4bc6fb3082d86958db7d4e35e9782fa2 100644
--- a/chrome/browser/ui/views/payments/editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/editor_view_controller.cc
@@ -61,11 +61,12 @@ std::unique_ptr<views::View> EditorViewController::CreateView() {
views::BoxLayout::CROSS_AXIS_ALIGNMENT_STRETCH);
content_view->SetLayoutManager(layout);
+ content_view->AddChildView(CreateHeaderView());
please use gerrit instead 2017/02/16 22:16:09 CreateHeaderView()->release(), when you start usin
Mathieu 2017/02/17 15:06:47 Done.
+
// Create an input label/textfield for each field definition.
std::vector<EditorField> fields = GetFieldDefinitions();
- for (const auto& field : fields) {
+ for (const auto& field : fields)
content_view->AddChildView(CreateInputField(field).release());
please use gerrit instead 2017/02/16 22:16:09 I thought {} were always required for the "for" lo
Mathieu 2017/02/17 15:06:47 Sure
- }
return CreatePaymentView(
CreateSheetHeaderView(

Powered by Google App Engine
This is Rietveld 408576698