Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2698263002: Revert "Revert "Reapply "Switch to the new analysis driver in analyzer_cli.""" (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Reapply "Switch to the new analysis driver in analyzer_cli.""" This reverts commit 64df435361535e9e64deadc98e2ee22507d19bb0. Originally landed as https://github.com/dart-lang/sdk/commit/cda7520e5c19425637351be5eae04af7e3136111 No new changes. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b7f17423da4b31d4bb8adcf33af422ded876c67d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 4 chunks +12 lines, -2 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-16 15:10:05 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-16 17:13:05 UTC) #2
scheglov
3 years, 10 months ago (2017-02-16 17:43:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7f17423da4b31d4bb8adcf33af422ded876c67d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698