Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 269823006: Move generated math methods from platform to codegen (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move generated math methods from platform to codegen BUG=none R=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -106 lines) Patch
M src/codegen.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M src/platform.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/platform-posix.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M src/platform-win32.cc View 3 chunks +0 lines, -66 lines 0 comments Download
M src/v8.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-05 13:05:58 UTC) #1
Michael Starzinger
LGTM.
6 years, 7 months ago (2014-05-06 08:56:39 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-06 11:14:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698