ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm - Issue 2698183002: [tab_container] Consolidate tabStrip into tab_container.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Issue 2698183002: [tab_container] Consolidate tabStrip into tab_container. (Closed)

Patch Set: Address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

index 51a42f855ef0711a9ffbbc33a8f6eef2e536448f..6d2a22070ea43edad5238d2c80a3a9fbc2a97c2b 100644

--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

@@ -17,8 +17,8 @@

#import "ios/clean/chrome/browser/ui/commands/tab_commands.h"

#import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"

#import "ios/clean/chrome/browser/ui/settings/settings_coordinator.h"

+#import "ios/clean/chrome/browser/ui/tab/tab_coordinator.h"

#import "ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h"

-#import "ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_coordinator.h"

#import "ios/shared/chrome/browser/coordinator_context/coordinator_context.h"

#import "ios/web/public/navigation_manager.h"

#include "ios/web/public/web_state/web_state.h"

@@ -97,8 +97,7 @@

#pragma mark - TabCommands

- (void)showTabAtIndexPath:(NSIndexPath*)indexPath {

- TabStripContainerCoordinator* tabCoordinator =

- [[TabStripContainerCoordinator alloc] init];

+ TabCoordinator* tabCoordinator = [[TabCoordinator alloc] init];

size_t index = static_cast<size_t>(indexPath.item);

DCHECK(index < _webStates.size());

tabCoordinator.webState = _webStates[index].get();