Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2698133003: MD Settings: About: Show connectionTypes message (Closed)
Patch Set: Rebase + Feedback + fix padding Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.html
diff --git a/chrome/browser/resources/settings/about_page/about_page.html b/chrome/browser/resources/settings/about_page/about_page.html
index 3e4f02952002eceba0941e2c5fd70f26d49ca3e6..5e93c8080e60b52e2c7ff4f6a91e7d7c17b45063 100644
--- a/chrome/browser/resources/settings/about_page/about_page.html
+++ b/chrome/browser/resources/settings/about_page/about_page.html
@@ -33,10 +33,23 @@
--about-page-image-space: 10px;
}
+ .block {
dpapad 2017/02/17 21:51:17 This rule does not have any effect, can we remove
stevenjb 2017/02/18 19:46:17 Huh, I didn't realize we had that, thanks. Done.
+ display: block;
+ }
+
.copyable {
-webkit-user-select: text;
}
+ .info-section {
+ margin-bottom: 12px;
+ }
+
+ .padded {
+ padding-bottom: 10px;
+ padding-top: 10px;
+ }
+
.product-title {
font-size: 153.85%; /* 20px / 13px */
margin-bottom: auto;
@@ -60,16 +73,6 @@
fill: var(--paper-red-600);
}
- .product-info {
- display: block;
- padding-bottom: 10px;
- padding-top: 10px;
- }
-
- .info-section {
- margin-bottom: 12px;
- }
-
#regulatoryInfo img {
width: 330px;
}
@@ -98,7 +101,7 @@
src="[[getIconSrc_(
obsoleteSystemInfo_, currentUpdateStatusEvent_)]]">
</iron-icon>
- <div class="start">
+ <div class="start padded">
<div id="updateStatusMessage" hidden="[[!showUpdateStatus_]]"
<if expr="not chromeos">
inner-h-t-m-l="[[getUpdateStatusMessage_(
@@ -182,7 +185,7 @@
</button>
</div>
</if>
- <div class="settings-box product-info copyable">
+ <div class="settings-box padded block copyable">
<div class="info-section">
<div class="secondary">$i18n{aboutProductTitle}</div>
<div class="secondary">$i18n{aboutProductCopyright}</div>
@@ -199,7 +202,7 @@
</if>
</div>
<if expr="chromeos">
- <div class="settings-box product-info" id="regulatoryInfo"
+ <div class="settings-box padded block" id="regulatoryInfo"
hidden$="[[!shouldShowRegulatoryInfo_(regulatoryInfo_)]]">
<img src="[[regulatoryInfo_.url]]" alt="[[regulatoryInfo_.text]]">
</div>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698