MD Settings: About: Show connectionTypes message

chrome/test/data/webui/settings/about_page_tests.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_about_page', function() {
   /**
    * @constructor
    * @implements {settings.AboutPageBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
@@ skipping 42 matching lines @@
   };
 
   TestAboutPageBrowserProxy.prototype = {
     __proto__: settings.TestBrowserProxy.prototype,
 
     /** @param {!UpdateStatus} updateStatus */
     setUpdateStatus: function(updateStatus) {
       this.updateStatus_ = updateStatus;
     },
 
+    sendStatusNoInternet: function() {
+      cr.webUIListenerCallback('update-status-changed', {
+        progress: 0,
+        status: 'failed',

[dpapad, 2017/02/17 02:44:28]

UpdateStatus.FAILED

[stevenjb, 2017/02/17 20:02:41]

Done.

+        message: 'offline',
+        connectionTypes: 'no internet',
+      });
+    },
+
     /** @override */
-    pageReady: function() {
-      this.methodCalled('pageReady');
-    },
+    pageReady: function() { this.methodCalled('pageReady'); },
 
     /** @override */
     refreshUpdateStatus: function() {
       cr.webUIListenerCallback('update-status-changed', {
         progress: 1,
         status: this.updateStatus_,
       });
       this.methodCalled('refreshUpdateStatus');
     },
 
     /** @override */
-    openFeedbackDialog: function() {
-      this.methodCalled('openFeedbackDialog');
-    },
+    openFeedbackDialog: function() { this.methodCalled('openFeedbackDialog'); },
 
     /** @override */
-    openHelpPage: function() {
-      this.methodCalled('openHelpPage');
-    },
+    openHelpPage: function() { this.methodCalled('openHelpPage'); },
   };
 
   if (cr.isMac) {
     /** @override */
     TestAboutPageBrowserProxy.prototype.promoteUpdater = function() {
       this.methodCalled('promoteUpdater');
     };
   }
 
   if (cr.isChromeOS) {
@@ skipping 247 matching lines @@
         fireStatusChanged(UpdateStatus.NEARLY_UPDATED);
         assertFalse(relaunch.hidden);
 
         var relaunch = page.$.relaunch;
         assertTrue(!!relaunch);
         MockInteractions.tap(relaunch);
         return lifetimeBrowserProxy.whenCalled('relaunch');
       });
 
       if (cr.isChromeOS) {
+        test('NoInternet', function() {
+          assertTrue(page.$.updateStatusMessage.hidden);
+          aboutBrowserProxy.sendStatusNoInternet();
+          Polymer.dom.flush();
+          assertFalse(page.$.updateStatusMessage.hidden);
+          assertNotEquals(
+              -1, page.$.updateStatusMessage.innerHTML.indexOf('no internet'));

[dpapad, 2017/02/17 02:44:28]

Nit (optional): You can use String#includes instead,
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje....

[stevenjb, 2017/02/17 20:02:41]

Huh. Good old JS, why have one method when you can have half a dozen? :)

+        });
+
         /**
          * Test that all buttons update according to incoming
          * 'update-status-changed' events for the case where target and current
          * channel are the same.
          */
         test('ButtonsUpdate_SameChannel', function() {
           var relaunch = page.$.relaunch;
           var checkForUpdates = page.$.checkForUpdates;
           var relaunchAndPowerwash = page.$.relaunchAndPowerwash;
 
@@ skipping 488 matching lines @@
     registerTests: function() {
       if (cr.isChromeOS) {
         registerDetailedBuildInfoTests();
         registerChannelSwitcherDialogTests();
       }
       registerAboutPageTests();
     },
     registerOfficialBuildTests: registerOfficialBuildTests,
   };
 });