Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2698133002: Remove PubSummaryManager. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove PubSummaryManager. The new AnalysisDriver is more general approach R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ab8aea145e6b01aaf48e3be84546854968015b22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2274 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +0 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 4 chunks +0 lines, -27 lines 0 comments Download
D pkg/analyzer/lib/src/summary/pub_summary.dart View 1 chunk +0 lines, -835 lines 0 comments Download
M pkg/analyzer/test/src/command_line/arguments_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analyzer/test/src/summary/pub_summary_test.dart View 1 chunk +0 lines, -1385 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-16 02:00:44 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-16 14:47:31 UTC) #2
scheglov
3 years, 10 months ago (2017-02-16 14:58:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab8aea145e6b01aaf48e3be84546854968015b22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698