Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 269813012: [Password Manager] Remove PSL matching for non-HTML forms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc
index 02339183aba8699ff6d4a6981a4973b965b75cbc..ef33e1f4c13dfb7b6debc2627fff704cb896e8aa 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc
@@ -164,7 +164,9 @@ void ConvertFormList(GList* found,
if (form) {
if (lookup_form && form->signon_realm != lookup_form->signon_realm) {
// This is not an exact match, we try PSL matching.
- if (!(PSLMatchingHelper::IsPublicSuffixDomainMatch(
+ if (lookup_form->scheme != PasswordForm::SCHEME_HTML ||
+ form->scheme != PasswordForm::SCHEME_HTML ||
+ !(PSLMatchingHelper::IsPublicSuffixDomainMatch(
lookup_form->signon_realm, form->signon_realm))) {
continue;
}

Powered by Google App Engine
This is Rietveld 408576698