[Password Manager] Remove PSL matching for non-HTML forms

chrome/browser/password_manager/native_backend_gnome_x.cc

Index: chrome/browser/password_manager/native_backend_gnome_x.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc
index 02339183aba8699ff6d4a6981a4973b965b75cbc..494b2ac101c497360550d2532f14857fe10884f6 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc
@@ -165,7 +165,9 @@ void ConvertFormList(GList* found,
       if (lookup_form && form->signon_realm != lookup_form->signon_realm) {
         // This is not an exact match, we try PSL matching.
         if (!(PSLMatchingHelper::IsPublicSuffixDomainMatch(
-                lookup_form->signon_realm, form->signon_realm))) {
+                lookup_form->signon_realm, form->signon_realm)) ||
+            lookup_form->scheme != PasswordForm::SCHEME_HTML ||

[vabr (Chromium), 2014/05/07 07:57:38]

optional nit: the added tests are cheaper than the IsPublicSuffixDomainMatch, so
I suggest putting them before the IsPublicSuffixDomainMatch -- if they return
true, it will spare some work.

Then again, this is probably not a performance hotspot, that's why the nit is
optional.

[Garrett Casto, 2014/05/08 20:01:20]

Done.

+            form->scheme != PasswordForm::SCHEME_HTML) {
           continue;
         }
         psl_domain_match_metric = PSLMatchingHelper::PSL_DOMAIN_MATCH_FOUND;