Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 269813003: Skipping WebRTC Firefox inteop test if there's no webcam on the system. (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Skipping WebRTC Firefox inteop test if there's no webcam on the system. All WebRTC bots used to have software webcams on them, but they don't anymore since we have transitioned to use internal fake video in Chrome for almost all the tests. However, Firefox doesn't AFAIK have the any fake device support which means this test needs a webcam on the executing system. This patch makes the code look for a webcam and skips the test if there is no webcam on the executing system. BUG=364418 TBR=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 4 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
6 years, 7 months ago (2014-05-05 09:30:56 UTC) #1
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-05 09:31:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/269813003/1
6 years, 7 months ago (2014-05-05 09:31:33 UTC) #3
henrika (OOO until Aug 14)
LGTM
6 years, 7 months ago (2014-05-05 09:32:15 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 13:22:01 UTC) #5
Message was sent while issue was closed.
Change committed as 268165

Powered by Google App Engine
This is Rietveld 408576698