Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/gn/command_args.cc

Issue 269813002: Fix GN args merge issue for https://codereview.chromium.org/265693003 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_args.cc
diff --git a/tools/gn/command_args.cc b/tools/gn/command_args.cc
index 9501681fe2de91071c76c64334e9d78c3d87f03f..65edc20a9d2abecaa6001c0636d4b1fbb3d93e9a 100644
--- a/tools/gn/command_args.cc
+++ b/tools/gn/command_args.cc
@@ -198,7 +198,7 @@ bool RunEditor(const base::FilePath& file_to_edit) {
#else // POSIX
-void RunEditor(const base::FilePath& file_to_edit) {
+bool RunEditor(const base::FilePath& file_to_edit) {
// Prefer $VISUAL, then $EDITOR, then vi.
const char* editor_ptr = getenv("VISUAL");
if (!editor_ptr)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698