Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Issue 2698123002: Avoid false-positives of paint offset change detection (method 2) (Closed)
Patch Set: - Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
diff --git a/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
index 969a6c3c16ed46a72aaae0e5d1aa7fc8f655a069..75febdd86ee849471d1e547dbc582d2d28030457 100644
--- a/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
+++ b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
@@ -215,25 +215,18 @@ void PrePaintTreeWalk::walk(const LayoutObject& object,
const PrePaintTreeWalkContext& parentContext) {
PrePaintTreeWalkContext context(parentContext);
- // This must happen before updateContextForBoxPosition, because the
- // latter reads some of the state computed uere.
- updateAuxiliaryObjectProperties(object, context);
-
- // Ensure the current context takes into account the box's position. This can
- // force a subtree update due to paint offset changes and must precede any
- // early out from the treewalk.
- m_propertyTreeBuilder.updateContextForBoxPosition(object,
- context.treeBuilderContext);
-
// Early out from the treewalk if possible.
if (!object.needsPaintPropertyUpdate() &&
!object.descendantNeedsPaintPropertyUpdate() &&
!context.treeBuilderContext.forceSubtreeUpdate &&
!context.paintInvalidatorContext.forcedSubtreeInvalidationFlags &&
!object
- .shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState()) {
+ .shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState())
return;
- }
+
+ // This must happen before updatePropertiesForSelf, because the latter reads
+ // some of the state computed here.
+ updateAuxiliaryObjectProperties(object, context);
m_propertyTreeBuilder.updatePropertiesForSelf(object,
context.treeBuilderContext);
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698