Allow embedder to use custom cryptography in Autofill table.

components/autofill/core/browser/webdata/autofill_table_encryptor_factory.h

+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_WEBDATA_SERVICES_AUTOFILL_TABLE_ENCRYPTOR_FACTORY_H_
+#define COMPONENTS_WEBDATA_SERVICES_AUTOFILL_TABLE_ENCRYPTOR_FACTORY_H_
+
+#include <memory>
+
+#include "base/memory/singleton.h"
+#include "base/sequence_checker.h"
+#include "components/autofill/core/browser/webdata/autofill_table_encryptor.h"
+
+namespace autofill {
+// Factory for creating Autofill table encryptor.
+// If |delegate_| is set, then |delegate_| is used to create encryptor,
+// else default encrytor (SystemEncryptor) is returned.
+template <typename T>
+struct DefaultSingletonTraits;
+class AutofillTableEncryptorFactory {
+ public:
+  // Embedders are recommended to use this delegate to inject
+  // their encryptor into Autofill table.
+  class Delegate {
+   public:
+    virtual std::unique_ptr<AutofillTableEncryptor> Create();
+  };
+
+  static AutofillTableEncryptorFactory* GetInstance();
+
+  std::unique_ptr<AutofillTableEncryptor> Create();
+
+  void SetDelegate(std::unique_ptr<Delegate> delegate);
+
+ private:
+  AutofillTableEncryptorFactory();

[Roger McFarlane (Chromium), 2017/02/22 18:01:27]

you need an explicitly public out-of-line destructor

(per linter)

[devarajn, 2017/02/22 18:13:56]

Sorry, I could not understand properly.
Do you mean a destructor in private
~AutofillTableEncryptorFactory() {}

Thank you

[Roger McFarlane (Chromium), 2017/02/22 18:32:56]

Check the compilation/lint failures of the try bots for patchset 2

[devarajn, 2017/02/22 18:56:58]

Acknowledged.

+  std::unique_ptr<Delegate> delegate_;
+  base::SequenceChecker sequence_checker_;
+
+  friend struct base::DefaultSingletonTraits<AutofillTableEncryptorFactory>;
+  DISALLOW_COPY_AND_ASSIGN(AutofillTableEncryptorFactory);
+};
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_WEBDATA_SERVICES_AUTOFILL_TABLE_ENCRYPTOR_FACTORY_H_