chrome/browser/diagnostics/OWNERS - Issue 2698093002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/diagnostics/OWNERS

Issue 2698093002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Patch Set: update component Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 cpu@chromium.org	1 cpu@chromium.org

	2

	3 # COMPONENT: Platform>Apps>Diagnostics>Connectivity
	grt (UTC plus 2) 2017/02/20 09:20:20 this isn't an apps thing. check with chrisha@ to s this isn't an apps thing. check with chrisha@ to see what he thinks -- i think he's done something in here recently. ymzhang1 2017/02/21 18:28:43 Done. Show quoted text On 2017/02/20 09:20:20, grt (UTC plus 1) wrote: > this isn't an apps thing. check with chrisha@ to see what he thinks -- i think > he's done something in here recently. Done. chrisha 2017/02/24 18:40:10 Definitely not an apps thing. This code runs when Show quoted text On 2017/02/21 18:28:43, ymzhang1 wrote: > On 2017/02/20 09:20:20, grt (UTC plus 1) wrote: > > this isn't an apps thing. check with chrisha@ to see what he thinks -- i think > > he's done something in here recently. > > Done. Definitely not an apps thing. This code runs when a Chrome installation is having trouble starting up, and it will restart in "diagnostics" mode. This component checks some simple things (databases for corruption, missing corrupt/files, etc). AFAICT this is only still used on ChromeOS. The work I did here was to remove the "conflicting modules" diagnostics component, as the backing code was ancient and XP specific, which we no longer support. Maybe PlatformIntegration makes sense? ymzhang1 2017/02/24 19:16:14 Replaced with Internals>PlatformIntegration. Show quoted text On 2017/02/24 18:40:10, chrisha wrote: > On 2017/02/21 18:28:43, ymzhang1 wrote: > > On 2017/02/20 09:20:20, grt (UTC plus 1) wrote: > > > this isn't an apps thing. check with chrisha@ to see what he thinks -- i > think > > > he's done something in here recently. > > > > Done. > > Definitely not an apps thing. This code runs when a Chrome installation is > having trouble starting up, and it will restart in "diagnostics" mode. This > component checks some simple things (databases for corruption, missing > corrupt/files, etc). > > AFAICT this is only still used on ChromeOS. > > The work I did here was to remove the "conflicting modules" diagnostics > component, as the backing code was ancient and XP specific, which we no longer > support. > > Maybe PlatformIntegration makes sense? Replaced with Internals>PlatformIntegration.
OLD	NEW

« base/win/OWNERS ('K') | « chrome/browser/component_updater/OWNERS ('k') | chrome/browser/extensions/component_extensions_whitelist/OWNERS » ('j') | chrome/browser/first_run/OWNERS » ('J')