Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tracing/bin/symbolize_trace

Issue 2698083004: Fix a bug introduced in a refactor to the ELFSymbolizer. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/bin/symbolize_trace
diff --git a/tracing/bin/symbolize_trace b/tracing/bin/symbolize_trace
index adb26739cce3c75165c50ab153e0cb2cde19d0c3..fd973fa09f50f6021ddc9c1e4e0c6a2c999265a5 100755
--- a/tracing/bin/symbolize_trace
+++ b/tracing/bin/symbolize_trace
@@ -65,7 +65,7 @@ class Symbolizer(object):
self.binary = 'addr2line'
self.symbolizer_path = FindInSystemPath(self.binary)
- def _SymbolizeLinuxAndAndroid(self, symfile):
+ def _SymbolizeLinuxAndAndroid(self, symfile, unsymbolized_name):
def _SymbolizerCallback(sym_info, frames):
# Unwind inline chain to the top.
while sym_info.inlined_by:
@@ -118,11 +118,11 @@ class Symbolizer(object):
processed_keys_count += len(keys_to_process)
all_keys = all_keys[input_count:]
- def Symbolize(self, symfile):
+ def Symbolize(self, symfile, unsymbolized_name):
if self.is_mac:
self._SymbolizeMac(symfile)
else:
- self._SymbolizeLinuxAndAndroid(symfile)
+ self._SymbolizeLinuxAndAndroid(symfile, unsymbolized_name)
def IsSymbolizableFile(file_path):
@@ -379,7 +379,7 @@ def SymbolizeFiles(symfiles, symbolizer):
len(symfile.frames_by_address),
symfile.path)
- symbolizer.Symbolize(symfile)
+ symbolizer.Symbolize(symfile, unsymbolized_name)
symbolized = True
return symbolized
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698