Wire up Skia axis parameters to HarfBuzz

third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

 /*
  * Copyright (c) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 369 matching lines @@
   return cacheEntry;
 }
 
 hb_font_t* HarfBuzzFace::getScaledFont(
     PassRefPtr<UnicodeRangeSet> rangeSet) const {
   m_platformData->setupPaint(&m_harfBuzzFontData->m_paint);
   m_harfBuzzFontData->m_paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
   m_harfBuzzFontData->m_rangeSet = rangeSet;
   m_harfBuzzFontData->updateSimpleFontData(m_platformData);
 
-  // TODO crbug.com/674879 - Connect variation axis parameters to future
-  // HarfBuzz API here.
   ASSERT(m_harfBuzzFontData->m_simpleFontData);
   int scale = SkiaScalarToHarfBuzzPosition(m_platformData->size());
   hb_font_set_scale(m_unscaledFont, scale, scale);
+
+  SkTypeface* typeface = m_harfBuzzFontData->m_paint.getTypeface();
+  int axisCount = typeface->getVariationDesignPosition(nullptr, 0);
+  if (axisCount > 0) {
+    Vector<SkFontArguments::VariationPosition::Coordinate> axisValues;
+    axisValues.resize(axisCount);
+    typeface->getVariationDesignPosition(axisValues.data(), axisValues.size());
+    Vector<float> axisValuesFloat;
+    axisValuesFloat.resize(axisCount);
+    for (size_t i = 0; i < axisValues.size(); i++) {
+      axisValuesFloat[i] = axisValues[i].value;
+    }
+    hb_font_set_var_coords_design(m_unscaledFont, axisValuesFloat.data(),
+                                  axisValuesFloat.size());
+  }

[behdad, 2017/02/17 19:13:49]

Shouldn't you set_var_coords to zero in the else branch?  Aren't we reusing
hb_font's?  Maybe just remove the conditional.

+
   return m_unscaledFont;
 }
 
 }  // namespace blink