Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2698013003: Fix strong mode errors introduced by b62a37a36b2d01c3c27979a2cf5eada24afce035. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix strong mode errors introduced by b62a37a36b2d01c3c27979a2cf5eada24afce035. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7aeba7513d72ea943819c45ada4fd11620d0a44d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-15 17:38:45 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-15 18:30:54 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 7aeba7513d72ea943819c45ada4fd11620d0a44d (presubmit successful).
3 years, 10 months ago (2017-02-15 18:35:38 UTC) #5
ahe
What was the error?
3 years, 10 months ago (2017-02-15 21:39:22 UTC) #6
ahe
3 years, 10 months ago (2017-02-15 21:41:22 UTC) #7
Message was sent while issue was closed. 
lgtm

Thank you, I saw the email from Brian.

Powered by Google App Engine
This is Rietveld 408576698