Issue 26980003: Make code slightly less complicated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26980003: Make code slightly less complicated. (Closed)

Created:
7 years, 2 months ago by Nico

Modified:
7 years, 2 months ago

Reviewers:
haraken, Nils Barth (inactive)

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make code slightly less complicated. idl_files_list contains the contents of idl_files, so `cat <(idl_files_list)` will always evaluate to idl_files. No need to shell out to cat for this. No functionality change. This was added in https://bugs.webkit.org/show_bug.cgi?id=73394 BUG=none R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159558

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/derived_sources.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26980003/1

7 years, 2 months ago (2013-10-14 04:20:05 UTC) #3

Nico

Committed patchset #1 manually as r159558 (presubmit successful).

7 years, 2 months ago (2013-10-14 05:16:48 UTC) #4

Nils Barth (inactive)

7 years, 2 months ago (2013-10-18 01:09:08 UTC) #5

Message was sent while issue was closed.

For the record, this was clobbered in:
Support partial interface for test support idls 
https://codereview.chromium.org/24053003/ 

(See Nico's comment)
https://codereview.chromium.org/24053003/#msg50 

...and will be reapplied in:
Reapply/merge derived_sources.gyp useless use of cat
https://codereview.chromium.org/27873002/

Expand Messages | Collapse Messages