Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2697953004: Add support for generating external types in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 0c5982879a5c03ff2343d25650fb3eec12dffdd0..d48139e41bc1a516070f0c8e8720ef6f47b9b0e3 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -68,7 +68,10 @@
"flag",
// Field is stored as a bool, whose default value is false
// and can only be set to true. Has a initial/getter/setter.
- "monotonic_flag"
+ "monotonic_flag",
+ // Field has type specified at field_type_path and has a getter/setter.
+ // Also has a setter taking an rvalue reference. Cannot be packed.
+ "external",
],
},
@@ -90,9 +93,12 @@
default: [],
},
- // - initial_keyword: "keyword-value"
- // This specifies the initial keyword value for the keyword fields.
- initial_keyword: {
+ // - default_value: "keyword-value"
+ // This specifies the default value for this field.
+ // - for keyword fields, this is the initial keyword
+ // - for other fields, this is a string containg the C++ expression
+ // that is used to initialise the field.
+ default_value: {
},
// Flags which go into CSSOMTypes:
@@ -332,7 +338,7 @@
custom_value: true,
field_type_path: "platform/text/TextDirection",
inherited: true,
- initial_keyword: "ltr",
+ default_value: "ltr",
field_template: "keyword",
keywords: ["ltr", "rtl"],
priority: "High",
@@ -485,7 +491,7 @@
custom_value: true,
field_type_path: "platform/text/WritingMode",
inherited: true,
- initial_keyword: "horizontal-tb",
+ default_value: "horizontal-tb",
field_template: "keyword",
keywords: ["horizontal-tb", "vertical-rl", "vertical-lr"],
priority: "High",
@@ -642,7 +648,7 @@
name: "border-collapse",
independent: true,
inherited: true,
- initial_keyword: "separate",
+ default_value: "separate",
field_template: "keyword",
keywords: ["separate", "collapse"],
},
@@ -769,7 +775,7 @@
name: "break-after",
// Storage for this property also covers these legacy properties:
// page-break-after, -webkit-column-break-after
- initial_keyword: "auto",
+ default_value: "auto",
field_template: "keyword",
keywords: [
"auto", "avoid", "avoid-column", "avoid-page", "column", "left", "page", "recto", "right", "verso"
@@ -780,7 +786,7 @@
name: "break-before",
// Storage for this property also covers these legacy properties:
// page-break-before, -webkit-column-break-before
- initial_keyword: "auto",
+ default_value: "auto",
field_template: "keyword",
keywords: [
"auto", "avoid", "avoid-column", "avoid-page", "column", "left", "page", "recto", "right", "verso"
@@ -791,7 +797,7 @@
name: "break-inside",
// Storage for this property also covers these legacy properties:
// page-break-inside, -webkit-column-break-inside
- initial_keyword: "auto",
+ default_value: "auto",
field_template: "keyword",
keywords: ["auto", "avoid", "avoid-column", "avoid-page"],
},
@@ -803,7 +809,7 @@
name: "caption-side",
independent: true,
inherited: true,
- initial_keyword: "top",
+ default_value: "top",
field_template: "keyword",
keywords: ["top", "bottom", "left", "right"],
},
@@ -817,7 +823,7 @@
},
{
name: "clear",
- initial_keyword: "none",
+ default_value: "none",
field_template: "keyword",
keywords: ["none", "left", "right", "both"],
},
@@ -924,7 +930,7 @@
name: "empty-cells",
independent: true,
inherited: true,
- initial_keyword: "show",
+ default_value: "show",
field_template: "keyword",
keywords: ["show", "hide"],
type_name: "EEmptyCells",
@@ -983,7 +989,7 @@
"flex-wrap",
{
name: "float",
- initial_keyword: "none",
+ default_value: "none",
field_template: "keyword",
keywords: ["none", "left", "right"],
name_for_methods: "Floating",
@@ -1177,14 +1183,14 @@
name: "list-style-position",
independent: true,
inherited: true,
- initial_keyword: "outside",
+ default_value: "outside",
field_template: "keyword",
keywords: ["outside", "inside"],
},
{
name: "list-style-type",
inherited: true,
- initial_keyword: "disc",
+ default_value: "disc",
field_template: "keyword",
keywords: [
"disc", "circle", "square", "decimal", "decimal-leading-zero", "arabic-indic", "bengali", "cambodian", "khmer", "devanagari", "gujarati", "gurmukhi", "kannada", "lao", "malayalam", "mongolian", "myanmar", "oriya", "persian", "urdu", "telugu", "tibetan", "thai", "lower-roman", "upper-roman", "lower-greek", "lower-alpha", "lower-latin", "upper-alpha", "upper-latin", "cjk-earthly-branch", "cjk-heavenly-stem", "ethiopic-halehame", "ethiopic-halehame-am", "ethiopic-halehame-ti-er", "ethiopic-halehame-ti-et", "hangul", "hangul-consonant", "korean-hangul-formal", "korean-hanja-formal", "korean-hanja-informal", "hebrew", "armenian", "lower-armenian", "upper-armenian", "georgian", "cjk-ideographic", "simp-chinese-formal", "simp-chinese-informal", "trad-chinese-formal", "trad-chinese-informal", "hiragana", "katakana", "hiragana-iroha", "katakana-iroha", "none",
@@ -1400,7 +1406,7 @@
name: "overflow-anchor",
runtime_flag: "ScrollAnchoring",
inherited: false,
- initial_keyword: "auto",
+ default_value: "auto",
field_template: "keyword",
keywords: [
"visible", "none", "auto",
@@ -1412,7 +1418,7 @@
},
{
name: "overflow-x",
- initial_keyword: "visible",
+ default_value: "visible",
field_template: "keyword",
keywords: [
"visible", "hidden", "scroll", "auto", "overlay", "-webkit-paged-x", "-webkit-paged-y",
@@ -1421,7 +1427,7 @@
},
{
name: "overflow-y",
- initial_keyword: "visible",
+ default_value: "visible",
field_template: "keyword",
keywords: [
"visible", "hidden", "scroll", "auto", "overlay", "-webkit-paged-x", "-webkit-paged-y",
@@ -1483,7 +1489,7 @@
name: "pointer-events",
independent: true,
inherited: true,
- initial_keyword: "auto",
+ default_value: "auto",
field_template: "keyword",
keywords: [
"none", "auto", "stroke", "fill", "painted", "visible", "visibleStroke", "visibleFill", "visiblePainted", "bounding-box", "all",
@@ -1492,7 +1498,7 @@
{
name: "position",
custom_inherit: true,
- initial_keyword: "static",
+ default_value: "static",
field_template: "keyword",
keywords: [
"static", "relative", "absolute", "fixed", "sticky",
@@ -1708,7 +1714,7 @@
},
{
name: "table-layout",
- initial_keyword: "auto",
+ default_value: "auto",
field_template: "keyword",
keywords: [
"auto", "fixed"
@@ -1726,7 +1732,7 @@
name: "text-align",
custom_value: true,
inherited: true,
- initial_keyword: "start",
+ default_value: "start",
field_template: "keyword",
keywords: [
"left", "right", "center", "justify", "webkitLeft", "webkitRight", "webkitCenter", "start", "end",
@@ -1822,7 +1828,7 @@
name: "text-transform",
independent: true,
inherited: true,
- initial_keyword: "none",
+ default_value: "none",
field_template: "keyword",
keywords: ["capitalize", "uppercase", "lowercase", "none"],
},
@@ -1897,7 +1903,7 @@
{
name: "unicode-bidi",
field_type_path: "platform/text/UnicodeBidi",
- initial_keyword: "normal",
+ default_value: "normal",
field_template: "keyword",
keywords: [
"normal", "embed", "bidi-override", "isolate", "plaintext", "isolate-override",
@@ -1920,7 +1926,7 @@
name: "visibility",
independent: true,
inherited: true,
- initial_keyword: "visible",
+ default_value: "visible",
interpolable: true,
field_template: "keyword",
keywords: ["visible", "hidden", "collapse"],
@@ -1986,7 +1992,7 @@
name: "-webkit-box-direction",
independent: true,
inherited: true,
- initial_keyword: "normal",
+ default_value: "normal",
field_template: "keyword",
keywords: ["normal", "reverse"],
},
@@ -2191,7 +2197,7 @@
name: "-webkit-print-color-adjust",
independent: true,
inherited: true,
- initial_keyword: "economy",
+ default_value: "economy",
field_template: "keyword",
keywords: ["economy", "exact"],
},
@@ -2200,7 +2206,7 @@
independent: true,
inherited: true,
initial: "initialRtlOrdering",
- initial_keyword: "logical",
+ default_value: "logical",
field_template: "keyword",
keywords: ["logical", "visual"],
setter: "setRtlOrdering",
@@ -2301,7 +2307,7 @@
name: "white-space",
independent: true,
inherited: true,
- initial_keyword: "normal",
+ default_value: "normal",
field_template: "keyword",
keywords: ["normal", "pre", "pre-wrap", "pre-line", "nowrap", "-webkit-nowrap"],
},
« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698