third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl - Issue 2697953004: Add support for generating external types in ComputedStyleBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2697953004: Add support for generating external types in ComputedStyleBase. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

index 2f1fc578035e3504e31aaadef5564a9349624082..0279075420ed020b739aa1cce188f55b3d1585db 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

@@ -7,7 +7,10 @@

namespace blink {

struct SameSizeAsComputedStyleBase {

- unsigned m_bitfields[{{expected_total_field_bytes}}];

+ {% for type_name, fields_list in fields|rejectattr("size")|groupby('type_name') %}

+ {{type_name}} m_{{type_name}}[{{fields_list|length}}];

+ {% endfor %}

+ unsigned m_bitfields[{{expected_bitfield_bytes}}];

};

// If this fails, the packing algorithm in make_computed_style_base.py has

// failed to produce the optimal packed size. To fix, update the algorithm to