chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Add some comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/BaseAppGlobals.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/BaseAppGlobals.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 4f2752ae28b4c3090706c5267dd4d9f6de7cfbc3..e1e6009b2802ed1a8b7d222f52b64a7b001e4c65 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -746,8 +746,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

if (syncController != null && syncController.isSyncingUrlsWithKeystorePassphrase()) {

assert syncService != null;

- mContextReporter = ((ChromeApplication) getApplicationContext()).createGsaHelper()

- .getContextReporter(this);

+ mContextReporter = AppGlobals.get().createGsaHelper().getContextReporter(this);

if (mSyncStateChangedListener != null) {

syncService.removeSyncStateChangedListener(mSyncStateChangedListener);