chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/ExternalEstimateProviderAndroid.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java b/chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java

index 3230801e7f2f73666d47f4e2b323eef9471f7a67..b6af9617e5e7ff31d08b94aae66a3c5c9e7b96be 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaDelegateBase.java

@@ -9,7 +9,7 @@ import android.content.pm.ApplicationInfo;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.ApplicationStatus;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppHooks;

import java.util.UUID;

@@ -53,6 +53,6 @@ public abstract class OmahaDelegateBase extends OmahaDelegate {

@Override

protected RequestGenerator createRequestGenerator(Context context) {

- return ((ChromeApplication) context.getApplicationContext()).createOmahaRequestGenerator();

+ return AppHooks.get().createOmahaRequestGenerator();

}