chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/VideoPersister.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/ExternalEstimateProviderAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

index bb17f878bd6c1814703b546c46c86b7fc3d174ae..9ffba3e3cb1ad4b7bd45e818479602b2e597a3c9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

@@ -17,9 +17,8 @@ import android.text.TextUtils;

import org.chromium.base.ActivityState;

import org.chromium.base.ApplicationStatus;

import org.chromium.base.ApplicationStatus.ActivityStateListener;

-import org.chromium.base.ContextUtils;

import org.chromium.base.VisibleForTesting;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.ChromeTabbedActivity;

import org.chromium.chrome.browser.ChromeTabbedActivity2;

import org.chromium.chrome.browser.IntentHandler;

@@ -57,9 +56,7 @@ public class MultiWindowUtils implements ActivityStateListener {

public static MultiWindowUtils getInstance() {

if (sInstance.get() == null) {

- ChromeApplication application =

- (ChromeApplication) ContextUtils.getApplicationContext();

- sInstance.compareAndSet(null, application.createMultiWindowUtils());

+ sInstance.compareAndSet(null, AppHooks.get().createMultiWindowUtils());

}

return sInstance.get();

}