chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/datausage/ExternalDataUseObserver.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java

index 79fe0209192e9c38fc5473eb74a592f22a4e1eb6..0084faf6293a365c123f166cb1c9b879913bdfa3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java

@@ -12,7 +12,7 @@ import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;

import org.chromium.chrome.browser.feedback.FeedbackCollector;

import org.chromium.chrome.browser.feedback.FeedbackReporter;

@@ -60,8 +60,7 @@ public final class DomDistillerUIUtils {

if (activity == null) return;

if (sFeedbackReporter == null) {

- ChromeApplication application = (ChromeApplication) activity.getApplication();

- sFeedbackReporter = application.createFeedbackReporter();

+ sFeedbackReporter = AppHooks.get().createFeedbackReporter();

}

FeedbackCollector.create(activity, Profile.getLastUsedProfile(), url,

new FeedbackCollector.FeedbackResult() {