Remove factory methods from ChromeApplication.

chrome/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//android_webview/webview_repack_locales_list.gni")
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/util/process_version.gni")
 import("//chrome/android/chrome_public_apk_tmpl.gni")
 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
@@ skipping 132 matching lines @@
     "values-sw/android_chrome_strings.xml",
     "values-th/android_chrome_strings.xml",
     "values-tr/android_chrome_strings.xml",
     "values-uk/android_chrome_strings.xml",
     "values-vi/android_chrome_strings.xml",
     "values-zh-rCN/android_chrome_strings.xml",
     "values-zh-rTW/android_chrome_strings.xml",
   ]
 }
 
+android_library("app_globals_java") {
+  java_files = [ app_globals_file ]
+  deps = [
+    ":chrome_java",
+    "//base:base_java",
+    "//components/signin/core/browser/android:java",
+  ]
+}
+
 android_library("chrome_java") {
   deps = [
     ":chrome_java_resources",
     ":chrome_public_android_manifest",
     ":chrome_public_apk_template_resources",
     ":document_tab_model_info_proto_java",
     "//base:base_java",
     "//chrome/android/webapk/libs/client:client_java",
     "//chrome/android/webapk/libs/common:common_java",
     "//chrome/android/webapk/libs/runtime_library:webapk_service_aidl_java",
@@ skipping 83 matching lines @@
     "//components/omnibox/browser:autocomplete_match_javagen",
     "//components/omnibox/browser:autocomplete_match_type_javagen",
     "//components/security_state/core:security_state_enums_java",
     "//components/signin/core/browser:investigated_scenario_java",
   ]
 
   # Manifest used for linting (determining unused resources).
   android_manifest = chrome_public_android_manifest
 
   # From java_sources.gni.
-  java_files = chrome_java_sources
+  java_files = chrome_java_sources + [ app_globals_file ]
 
   if (enable_webvr) {
     java_files += chrome_vr_java_sources
     deps += [ "//third_party/gvr-android-sdk:gvr_common_java" ]
   }
+
+  # Add the actual implementation where necessary so that downstream targets
+  # can provide their own implementations.
+  jar_excluded_patterns = [
+    "*/AppGlobals.class",
+    "*/AppGlobals\$*.class",
+  ]
 }
 
 action("chrome_android_java_google_api_keys_srcjar") {
   script = "//build/android/gyp/java_google_api_keys.py"
   _output_path = "$target_gen_dir/$target_name.srcjar"
   outputs = [
     _output_path,
   ]
   args = [
     "--srcjar",
@@ skipping 30 matching lines @@
   package_name = "org/chromium/chrome/browser"
   inputs = [
     "../browser/android/resource_id.h",
   ]
 }
 
 junit_binary("chrome_junit_tests") {
   # From java_sources.gni.
   java_files = chrome_junit_test_java_sources
   deps = [
+    ":app_globals_java",
     ":chrome_java",
     ":chrome_java_resources",
     "//base:base_java",
     "//base:base_java_test_support",
     "//chrome/android/webapk/libs/client:client_java",
     "//chrome/android/webapk/libs/common:common_java",
     "//chrome/android/webapk/test:junit_test_support",
     "//chrome/test/android:chrome_java_test_support",
     "//components/bookmarks/common/android:bookmarks_java",
     "//components/invalidation/impl:java",
@@ skipping 50 matching lines @@
 
 android_library("chrome_test_java") {
   testonly = true
 
   # From java_sources.gni.
   java_files = chrome_test_java_sources
 
   deps = [
     "//base:base_java",
     "//base:base_java_test_support",
+    "//chrome/android:app_globals_java",
     "//chrome/android:chrome_java",
     "//chrome/android/webapk/libs/client:client_java",
     "//chrome/android/webapk/libs/common:common_java",
     "//chrome/android/webapk/libs/runtime_library:webapk_service_aidl_java",
     "//chrome/test/android:chrome_java_test_support",
     "//components/autofill/android:autofill_java",
     "//components/bookmarks/common/android:bookmarks_java",
     "//components/dom_distiller/core/android:dom_distiller_core_java",
     "//components/gcm_driver/android:gcm_driver_java",
     "//components/gcm_driver/instance_id/android:instance_id_driver_java",
@@ skipping 70 matching lines @@
 
   java_files = [
     "javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java",
     "javatests/src/org/chromium/chrome/browser/vr_shell/MockVrDaydreamApi.java",
     "javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java",
   ]
 
   deps = [
     "//base:base_java",
     "//base:base_java_test_support",
+    "//chrome/android:app_globals_java",
     "//chrome/android:chrome_java",
     "//chrome/test/android:chrome_java_test_support",
     "//components/policy/android:policy_java",
     "//content/public/android:content_java",
     "//content/public/test/android:content_java_test_support",
     "//third_party/android_protobuf:protobuf_nano_javalib",
     "//third_party/android_support_test_runner:runner_java",
     "//third_party/android_tools:android_support_v7_appcompat_java",
     "//third_party/gvr-android-sdk:gvr_common_java",
     "//ui/android:ui_java",
@@ skipping 194 matching lines @@
 
 # Contains rules common to chrome_public_apk and chrome_sync_shell_apk
 template("chrome_public_apk_tmpl_shared") {
   chrome_public_apk_tmpl(target_name) {
     forward_variables_from(invoker, "*")
     if (!defined(deps)) {
       deps = []
     }
 
     deps += [
+      ":app_globals_java",
       ":chrome_java",
       ":chrome_public_apk_resources",
       ":chrome_public_non_pak_assets",
       ":chrome_public_pak_assets",
       "//base:base_java",
     ]
   }
 }
 
 chrome_public_apk_tmpl_shared("chrome_public_apk") {
@@ skipping 13 matching lines @@
   load_library_from_apk = chromium_linker_supported
 }
 
 monochrome_public_apk_tmpl("monochrome_public_apk") {
   android_manifest = monochrome_public_android_manifest
   android_manifest_dep = ":monochrome_public_android_manifest"
   apk_name = "MonochromePublic"
 
   deps = [
     "//base:base_java",
+    "//chrome/android:app_globals_java",
     "//chrome/android:chrome_java",
     "//chrome/android/java/templates:public_monochrome_java",
   ]
 }
 
 chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") {
   testonly = true
   android_manifest = chrome_sync_shell_android_manifest
   android_manifest_dep = ":chrome_sync_shell_android_manifest"
   apk_name = "ChromeSyncShell"
@@ skipping 71 matching lines @@
 
 android_library("chrome_sync_shell_test_apk_java") {
   testonly = true
 
   # From java_sources.jni.
   java_files = sync_shell_test_java_sources
 
   deps = [
     "//base:base_java",
     "//base:base_java_test_support",
+    "//chrome/android:app_globals_java",
     "//chrome/android:chrome_java",
     "//chrome/test/android:chrome_java_test_support",
     "//components/bookmarks/common/android:bookmarks_java",
     "//components/policy/android:policy_java",
     "//components/signin/core/browser/android:signin_java_test_support",
     "//components/sync:sync_java_test_support",
     "//components/sync:test_support_proto_java",
     "//components/sync/android:sync_java",
     "//content/public/android:content_java",
     "//content/public/test/android:content_java_test_support",
     "//third_party/android_protobuf:protobuf_nano_javalib",
     "//third_party/android_support_test_runner:runner_java",
     "//third_party/android_tools:android_support_v7_appcompat_java",
     "//ui/android:ui_java",
   ]
 }
 
 instrumentation_test_apk("chrome_sync_shell_test_apk") {
   apk_name = "ChromeSyncShellTest"
   apk_under_test = ":chrome_sync_shell_apk"
   android_manifest = chrome_sync_shell_test_apk_manifest
   android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
   deps = [
     ":chrome_sync_shell_test_apk_java",
     "//third_party/android_support_test_runner:runner_java",
   ]
   proguard_enabled = !is_java_debug
 }