Issue 269793004: installer: Remove dependency on extensions' constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269793004: installer: Remove dependency on extensions' constant. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
Yoyo Zhou, grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org, robert, James Cook, Yoyo Zhou

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

installer: Remove dependency on extensions' constant. Instead, just hardcode it directly where we used to reuse the constant from extensions library. BUG=368334 TEST=green trybots R=grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268166

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/installer/setup/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/installer/setup/uninstall.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

Yoyo Zhou

LGTM. Are there any gyp dependencies you can remove also?

6 years, 7 months ago (2014-05-03 06:43:46 UTC) #2

tfarina

On 2014/05/03 06:43:46, Yoyo Zhou wrote: > LGTM. Are there any gyp dependencies you can ...

6 years, 7 months ago (2014-05-03 16:50:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/269793004/1

6 years, 7 months ago (2014-05-05 10:12:58 UTC) #5

Message was sent while issue was closed.

Change committed as 268166