Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

Issue 2697923005: Remove unnecessary override of Node#cloneNode in ShadowRoot's WebIDL (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
index 420e4a08172bf2773c0d06cab780e0987ba76dd9..c42188879f724ffdbaf23ca0187e87ac7266b24f 100644
--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h
@@ -173,7 +173,7 @@ class CORE_EXPORT ShadowRoot final : public DocumentFragment, public TreeScope {
void invalidateDescendantInsertionPoints();
// ShadowRoots should never be cloned.
- Node* cloneNode(bool) override { return nullptr; }
+ // Node* cloneNode(bool, ExceptionState&) override { return nullptr; }
foolip 2017/02/16 13:56:12 Can you remove this and instead add override to th
hayato 2017/02/17 05:09:14 Done
Member<ShadowRootRareDataV0> m_shadowRootRareDataV0;
Member<StyleSheetList> m_styleSheetList;
« no previous file with comments | « third_party/WebKit/Source/core/dom/Text.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698