Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26979002: CSS Animations: Simplify interpolation test results under test-runner (Closed)

Created:
7 years, 2 months ago by dstockwell
Modified:
7 years, 2 months ago
Reviewers:
Steve Block
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

CSS Animations: Simplify interpolation test results under test-runner Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159633

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert webkit-column-count #

Patch Set 3 : Update expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -243 lines) Patch
M LayoutTests/animations/interpolation/background-color-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/background-position-interpolation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/animations/interpolation/border-color-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/border-image-outset-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/border-image-slice-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/border-image-width-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/border-radius-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/border-spacing-interpolation-expected.txt View 1 chunk +1 line, -16 lines 0 comments Download
M LayoutTests/animations/interpolation/border-width-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/bottom-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/calc-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/clip-interpolation-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/animations/interpolation/color-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/font-size-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/height-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/left-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/letter-spacing-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/margin-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/max-height-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/max-width-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/min-height-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/min-width-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/orphans-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/outline-color-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/outline-offset-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/outline-width-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/padding-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/perspective-interpolation-expected.txt View 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/animations/interpolation/perspective-origin-interpolation-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/animations/interpolation/resources/interpolation-test.js View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/right-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/sample-interpolation-test-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-baseline-shift-interpolation-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-fill-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-fill-opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-flood-color-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-kerning-interpolation-expected.txt View 1 chunk +1 line, -21 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-lighting-color-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-stop-color-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-stop-opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-dasharray-interpolation-expected.txt View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-dashoffset-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-miterlimit-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-width-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/text-decoration-color-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/text-indent-interpolation-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/animations/interpolation/top-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/transform-origin-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/webkit-clip-path-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-rule-color-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/webkit-shape-inside-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/animations/interpolation/webkit-text-fill-color-interpolation-expected.txt View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-text-stroke-color-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/widows-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/width-interpolation-expected.txt View 1 chunk +1 line, -11 lines 0 comments Download
M LayoutTests/animations/interpolation/word-spacing-interpolation-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/animations/interpolation/z-index-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/interpolation/zoom-iterpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/background-position-interpolation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/border-image-outset-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/border-image-slice-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/border-image-width-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/border-radius-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/border-spacing-interpolation-expected.txt View 1 chunk +1 line, -16 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/clip-interpolation-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/max-height-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/max-width-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/min-height-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/min-width-interpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/orphans-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/padding-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/perspective-origin-interpolation-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-fill-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-fill-opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-stop-opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-stroke-dasharray-interpolation-expected.txt View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-stroke-interpolation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-stroke-miterlimit-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-stroke-opacity-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/svg-stroke-width-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/transform-origin-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/widows-interpolation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/width-interpolation-expected.txt View 1 chunk +1 line, -11 lines 0 comments Download
M LayoutTests/virtual/web-animations-css/animations/interpolation/zoom-iterpolation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dstockwell
7 years, 2 months ago (2013-10-11 06:05:24 UTC) #1
Steve Block
https://codereview.chromium.org/26979002/diff/1/LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt File LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt (left): https://codereview.chromium.org/26979002/diff/1/LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt#oldcode19 LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt:19: PASS: -webkit-column-count from [0] to [5] was [6] at ...
7 years, 2 months ago (2013-10-11 06:21:22 UTC) #2
dstockwell
On 2013/10/11 06:21:22, Steve Block wrote: > https://codereview.chromium.org/26979002/diff/1/LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt > File > LayoutTests/animations/interpolation/webkit-column-count-interpolation-expected.txt > (left): > ...
7 years, 2 months ago (2013-10-11 06:35:59 UTC) #3
Steve Block
lgtm
7 years, 2 months ago (2013-10-11 06:41:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/26979002/5001
7 years, 2 months ago (2013-10-11 06:44:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=7748
7 years, 2 months ago (2013-10-11 07:51:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/26979002/22001
7 years, 2 months ago (2013-10-15 00:11:24 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-10-15 02:11:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/26979002/22001
7 years, 2 months ago (2013-10-15 02:30:06 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 02:31:29 UTC) #10
Message was sent while issue was closed. 
Change committed as 159633

Powered by Google App Engine
This is Rietveld 408576698