Merge the work on Generic Types Reification from 'dart-lang/reify' repo

Merge the work on Generic Types Reification from 'dart-lang/reify' repo

This CL adds the work done at https://github.com/dart-lang/reify to SDK.
The commit that is used for the merge is
a2066a68374d49de92ff75f5e1ffc36335fd9451 (Nov 23, 2016). The code is
adjusted to respect the changes of the kernel package in SDK since that
commit.

The reify transformation is run by specifying 'vmreify' target to
'dartk'. The transformation requires its runtime library to present in
the program being transformed. The library is found in its default
location in SDK checkout if 'dartk' is run from its default location in
SDK checkout. To preserve the library in the output, TreeShaker is
disabled in 'vmreify' target.

The "golden" set of tests is also copied from 'dart-lang/reify'
repository, and the appropriate test suite is defined for it.

The bash script 'bin/reified_dart' from 'dart-lang/reify' is rewritten
as Dart script 'pkg/kernel/bin/reified_dart.dart'. It requires path to
'dartk' and path to SDK. Those are taken from their default locations in
SDK if 'reified_dart.dart' is run from its default location in SDK.

The added files were formatted using 'dartfmt' with default settings.
Additionally, the files were checked with 'dartanalyzer --strong'. The
necessary changes were made to fix the error messages. There are some
'hint' and 'error' messages left for some .dart files from the added
test cases, but they reflect intentional errors or conventions in those
files.

R=asgerf@google.com, karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/d5e2fcb4304e993f8a1888dc9d0051124d16072c

[Dmitry Stefantsov, 2017-02-17 09:35:25]

dmitryas@google.com changed reviewers:
+ asgerf@google.com, karlklose@google.com, kmillikin@google.com

[asgerf, 2017-02-17 11:49:06]

Changes to dartk and lib/targets lgtm

[karlklose, 2017-02-17 12:35:19]

LGTM

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
File pkg/kernel/bin/reified_dart.dart (right):

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:53: var stat = new File(path).statSync();
How about 'type' or 'kind' instead of 'stat'? You could also switch on the
return value of 'statSync' directly.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:90: sdkPath = path.normalize(sdkPath);
Add call to 'normalize' to previous line?

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:120: if (sdkPath == null) {
Consider moving this whole logic into getDefaultSdk (and also getDefaultDartk
below).

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:150: ProcessResult result =
Process.runSync(dartkPath, [
Since main is already async you could also use 'await Process.run' (also below)

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:159: stderr.write(result.stderr);
Maybe print something like 'execution failed with exit code ${result.exitCode}'?

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:168: if (result.exitCode != 0) {
I would print result.stdOut even with failures.

This can share code with l. 174-176, for example,
  stdout.write(result.stdout);
  stderr.write(result.stderr);
  tmpFile?.parent?.delete(recursive: true); // You could also leave the file
there, the OS should remove it.
  if (result.exitCode != 0) {
    print('Execution failed with exit code ${result.exitCode}');
  }

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/t...
File pkg/kernel/lib/target/targets.dart (right):

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/t...
pkg/kernel/lib/target/targets.dart:22: TargetFlags({this.strongMode: false,
this.treeShake: false, this.programRoots: const <ProgramRoot>[],
this.kernelRuntime: null});
You do not need to write `null` here, it is the default default value.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/v...
File pkg/kernel/lib/target/vmreify.dart (right):

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/v...
pkg/kernel/lib/target/vmreify.dart:31:
super.performGlobalTransformations(program);
Please add a TODO here that we should make this a modular transformation.

[Dmitry Stefantsov, 2017-02-17 12:44:04]

Description was changed from

==========
Merge the work on Generic Types Reification from 'dart-lang/reify' repo

This CL adds the work done at https://github.com/dart-lang/reify to SDK.
The commit that is used for the merge is
a2066a68374d49de92ff75f5e1ffc36335fd9451 (Nov 23, 2016). The code is
adjusted to respect the changes of the kernel package in SDK since that
commit.

The GTR transformation is run by specifying 'vmgtr' target to 'dartk'.

The GTR transformation requires its runtime library to present in the
program being transformed. The path to the library is given by the
'--gtr-runtime' option to 'dartk'. To preserve the library in the
output, TreeShaker is disabled in 'vmgtr' target.

The "golden" set of tests is also copied from 'dart-lang/reify'
repository, and the appropriate test suite is defined for it. The suite
also requires the GTR runtime library path to be passed via Dart
environment flags, for example: dart
-DgtrRuntime=pkg/kernel/lib/transformations/reify/runtime
pkg/kernel/test/reify/suite.dart

The bash script 'bin/reified_dart' from 'dart-lang/reify' is rewritten
as Dart script 'pkg/kernel/bin/reified_dart.dart'. It needs path to
'dartk', path to SDK, and path to GTR runtime libraries. Those are taken
from their default locations in SDK if 'reified_dart.dart' is run from
its default location in SDK.

The added files were formatted using 'dartfmt' with default settings.
Additionally, the files were checked with 'dartanalyzer --strong'. The
necessary changes were made to fix the error messages. There are some
'hint' and 'error' messages left for some .dart files from the added
test cases, but they reflect intentional errors or conventions in those
files.
==========

to

==========
Merge the work on Generic Types Reification from 'dart-lang/reify' repo

This CL adds the work done at https://github.com/dart-lang/reify to SDK.
The commit that is used for the merge is
a2066a68374d49de92ff75f5e1ffc36335fd9451 (Nov 23, 2016). The code is
adjusted to respect the changes of the kernel package in SDK since that
commit.

The reify transformation is run by specifying 'vmreify' target to
'dartk'. The transformation requires its runtime library to present in
the program being transformed. The library is found in its default
location in SDK checkout if 'dartk' is run from its default location in
SDK checkout. To preserve the library in the output, TreeShaker is
disabled in 'vmreify' target.

The "golden" set of tests is also copied from 'dart-lang/reify'
repository, and the appropriate test suite is defined for it.

The bash script 'bin/reified_dart' from 'dart-lang/reify' is rewritten
as Dart script 'pkg/kernel/bin/reified_dart.dart'. It requires path to
'dartk' and path to SDK. Those are taken from their default locations in
SDK if 'reified_dart.dart' is run from its default location in SDK.

The added files were formatted using 'dartfmt' with default settings.
Additionally, the files were checked with 'dartanalyzer --strong'. The
necessary changes were made to fix the error messages. There are some
'hint' and 'error' messages left for some .dart files from the added
test cases, but they reflect intentional errors or conventions in those
files.
==========

[Dmitry Stefantsov, 2017-02-17 13:10:35]

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
File pkg/kernel/bin/reified_dart.dart (right):

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:53: var stat = new File(path).statSync();
On 2017/02/17 12:35:19, karlklose wrote:
> How about 'type' or 'kind' instead of 'stat'? You could also switch on the
> return value of 'statSync' directly.

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:90: sdkPath = path.normalize(sdkPath);
On 2017/02/17 12:35:19, karlklose wrote:
> Add call to 'normalize' to previous line?

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:120: if (sdkPath == null) {
On 2017/02/17 12:35:19, karlklose wrote:
> Consider moving this whole logic into getDefaultSdk (and also getDefaultDartk
> below).

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:150: ProcessResult result =
Process.runSync(dartkPath, [
On 2017/02/17 12:35:19, karlklose wrote:
> Since main is already async you could also use 'await Process.run' (also
below)

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:159: stderr.write(result.stderr);
On 2017/02/17 12:35:19, karlklose wrote:
> Maybe print something like 'execution failed with exit code
${result.exitCode}'?

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/bin/reified_...
pkg/kernel/bin/reified_dart.dart:168: if (result.exitCode != 0) {
On 2017/02/17 12:35:19, karlklose wrote:
> I would print result.stdOut even with failures.
> 
> This can share code with l. 174-176, for example,
>   stdout.write(result.stdout);
>   stderr.write(result.stderr);
>   tmpFile?.parent?.delete(recursive: true); // You could also leave the file
> there, the OS should remove it.
>   if (result.exitCode != 0) {
>     print('Execution failed with exit code ${result.exitCode}');
>   }

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/t...
File pkg/kernel/lib/target/targets.dart (right):

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/t...
pkg/kernel/lib/target/targets.dart:22: TargetFlags({this.strongMode: false,
this.treeShake: false, this.programRoots: const <ProgramRoot>[],
this.kernelRuntime: null});
On 2017/02/17 12:35:19, karlklose wrote:
> You do not need to write `null` here, it is the default default value.

Done.

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/v...
File pkg/kernel/lib/target/vmreify.dart (right):

https://codereview.chromium.org/2697873007/diff/20001/pkg/kernel/lib/target/v...
pkg/kernel/lib/target/vmreify.dart:31:
super.performGlobalTransformations(program);
On 2017/02/17 12:35:19, karlklose wrote:
> Please add a TODO here that we should make this a modular transformation.

Done.

[Dmitry Stefantsov, 2017-02-17 13:19:37]

Description was changed from

==========
Merge the work on Generic Types Reification from 'dart-lang/reify' repo

This CL adds the work done at https://github.com/dart-lang/reify to SDK.
The commit that is used for the merge is
a2066a68374d49de92ff75f5e1ffc36335fd9451 (Nov 23, 2016). The code is
adjusted to respect the changes of the kernel package in SDK since that
commit.

The reify transformation is run by specifying 'vmreify' target to
'dartk'. The transformation requires its runtime library to present in
the program being transformed. The library is found in its default
location in SDK checkout if 'dartk' is run from its default location in
SDK checkout. To preserve the library in the output, TreeShaker is
disabled in 'vmreify' target.

The "golden" set of tests is also copied from 'dart-lang/reify'
repository, and the appropriate test suite is defined for it.

The bash script 'bin/reified_dart' from 'dart-lang/reify' is rewritten
as Dart script 'pkg/kernel/bin/reified_dart.dart'. It requires path to
'dartk' and path to SDK. Those are taken from their default locations in
SDK if 'reified_dart.dart' is run from its default location in SDK.

The added files were formatted using 'dartfmt' with default settings.
Additionally, the files were checked with 'dartanalyzer --strong'. The
necessary changes were made to fix the error messages. There are some
'hint' and 'error' messages left for some .dart files from the added
test cases, but they reflect intentional errors or conventions in those
files.
==========

to

==========
Merge the work on Generic Types Reification from 'dart-lang/reify' repo

This CL adds the work done at https://github.com/dart-lang/reify to SDK.
The commit that is used for the merge is
a2066a68374d49de92ff75f5e1ffc36335fd9451 (Nov 23, 2016). The code is
adjusted to respect the changes of the kernel package in SDK since that
commit.

The reify transformation is run by specifying 'vmreify' target to
'dartk'. The transformation requires its runtime library to present in
the program being transformed. The library is found in its default
location in SDK checkout if 'dartk' is run from its default location in
SDK checkout. To preserve the library in the output, TreeShaker is
disabled in 'vmreify' target.

The "golden" set of tests is also copied from 'dart-lang/reify'
repository, and the appropriate test suite is defined for it.

The bash script 'bin/reified_dart' from 'dart-lang/reify' is rewritten
as Dart script 'pkg/kernel/bin/reified_dart.dart'. It requires path to
'dartk' and path to SDK. Those are taken from their default locations in
SDK if 'reified_dart.dart' is run from its default location in SDK.

The added files were formatted using 'dartfmt' with default settings.
Additionally, the files were checked with 'dartanalyzer --strong'. The
necessary changes were made to fix the error messages. There are some
'hint' and 'error' messages left for some .dart files from the added
test cases, but they reflect intentional errors or conventions in those
files.

R=asgerf@google.com, karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d5e2fcb4304e993f8a1888dc9d0051124d16072c
==========

[Dmitry Stefantsov, 2017-02-17 13:19:39]

Committed patchset #4 (id:60001) manually as
d5e2fcb4304e993f8a1888dc9d0051124d16072c (presubmit successful).