cc/output/gl_renderer.cc - Issue 2697863003: color: Clarify default behaviors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.cc

Issue 2697863003: color: Clarify default behaviors (Closed)

Patch Set: Incorporate review feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/gl_renderer.cc

diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc

index cb76e74e1456af40bdadeb35a597800259ba5acf..ff1b83812432068323fed4e467277d6a5d216c39 100644

--- a/cc/output/gl_renderer.cc

+++ b/cc/output/gl_renderer.cc

@@ -2109,6 +2109,9 @@ void GLRenderer::DrawYUVVideoQuad(const YUVVideoDrawQuad* quad,

break;

}

+ // Invalid or unspecified color spaces should be treated as REC709.

+ if (!src_color_space.IsValid())

+ src_color_space = gfx::ColorSpace::CreateREC709();

ResourceProvider::ScopedSamplerGL y_plane_lock(

resource_provider_, quad->y_plane_resource_id(), GL_TEXTURE1, GL_LINEAR);