Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: media/filters/h264_parser.cc

Issue 2697863003: color: Clarify default behaviors (Closed)
Patch Set: Incorporate review feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/ffmpeg_video_decoder.cc ('k') | media/filters/vpx_video_decoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/filters/h264_parser.h" 5 #include "media/filters/h264_parser.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 return gfx::Rect(crop_left, crop_top, 119 return gfx::Rect(crop_left, crop_top,
120 coded_size->width() - crop_left - crop_right, 120 coded_size->width() - crop_left - crop_right,
121 coded_size->height() - crop_top - crop_bottom); 121 coded_size->height() - crop_top - crop_bottom);
122 } 122 }
123 123
124 // Based on T-REC-H.264 E.2.1, "VUI parameters semantics", 124 // Based on T-REC-H.264 E.2.1, "VUI parameters semantics",
125 // available from http://www.itu.int/rec/T-REC-H.264. 125 // available from http://www.itu.int/rec/T-REC-H.264.
126 gfx::ColorSpace H264SPS::GetColorSpace() const { 126 gfx::ColorSpace H264SPS::GetColorSpace() const {
127 if (colour_description_present_flag) { 127 if (colour_description_present_flag) {
128 return gfx::ColorSpace( 128 return gfx::ColorSpace::CreateVideo(
129 colour_primaries, transfer_characteristics, matrix_coefficients, 129 colour_primaries, transfer_characteristics, matrix_coefficients,
130 video_full_range_flag ? gfx::ColorSpace::RangeID::FULL 130 video_full_range_flag ? gfx::ColorSpace::RangeID::FULL
131 : gfx::ColorSpace::RangeID::LIMITED); 131 : gfx::ColorSpace::RangeID::LIMITED);
132 } else { 132 } else {
133 return gfx::ColorSpace(gfx::ColorSpace::PrimaryID::UNSPECIFIED, 133 // TODO(ccameron/hubbe): Add a uniform way to handle default video frames.
134 gfx::ColorSpace::TransferID::UNSPECIFIED, 134 return gfx::ColorSpace(
135 gfx::ColorSpace::MatrixID::UNSPECIFIED, 135 gfx::ColorSpace::PrimaryID::BT709, gfx::ColorSpace::TransferID::BT709,
136 video_full_range_flag 136 gfx::ColorSpace::MatrixID::BT709,
137 ? gfx::ColorSpace::RangeID::FULL 137 video_full_range_flag ? gfx::ColorSpace::RangeID::FULL
138 : gfx::ColorSpace::RangeID::LIMITED); 138 : gfx::ColorSpace::RangeID::LIMITED);
139 } 139 }
140 } 140 }
141 141
142 H264PPS::H264PPS() { 142 H264PPS::H264PPS() {
143 memset(this, 0, sizeof(*this)); 143 memset(this, 0, sizeof(*this));
144 } 144 }
145 145
146 H264SliceHeader::H264SliceHeader() { 146 H264SliceHeader::H264SliceHeader() {
147 memset(this, 0, sizeof(*this)); 147 memset(this, 0, sizeof(*this));
148 } 148 }
(...skipping 1326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1475 1475
1476 default: 1476 default:
1477 DVLOG(4) << "Unsupported SEI message"; 1477 DVLOG(4) << "Unsupported SEI message";
1478 break; 1478 break;
1479 } 1479 }
1480 1480
1481 return kOk; 1481 return kOk;
1482 } 1482 }
1483 1483
1484 } // namespace media 1484 } // namespace media
OLDNEW
« no previous file with comments | « media/filters/ffmpeg_video_decoder.cc ('k') | media/filters/vpx_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698