color: Clarify default behaviors

ui/gfx/color_space.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_COLOR_SPACE_H_
 #define UI_GFX_COLOR_SPACE_H_
 
 #include <stdint.h>
 
 #include "base/gtest_prod_util.h"
@@ skipping 172 matching lines @@
   bool GetInverseTransferFunction(SkColorSpaceTransferFn* fn) const;
 
   // For most formats, this is the RGB to YUV matrix.
   void GetTransferMatrix(SkMatrix44* matrix) const;
   void GetRangeAdjustMatrix(SkMatrix44* matrix) const;
 
  private:
   PrimaryID primaries_ = PrimaryID::UNSPECIFIED;
   TransferID transfer_ = TransferID::UNSPECIFIED;
   MatrixID matrix_ = MatrixID::UNSPECIFIED;
-  RangeID range_ = RangeID::LIMITED;
+  RangeID range_ = RangeID::FULL;

[hubbe, 2017/02/15 08:48:56]

Maybe we should have an unspecified range?
I'm not sure if changing this will cause any problems or not...

[ccameron, 2017/02/15 09:34:28]

Not sure what to do here. The default gfx::ColorSpace for everything-but-video
should be sRGB (or "don't convert"), so FULL makes more sense here.

 
   // Only used if primaries_ is PrimaryID::CUSTOM.
   float custom_primary_matrix_[9] = {0, 0, 0, 0, 0, 0, 0, 0};
 
   // Only used if transfer_ is TransferID::CUSTOM. This array consists of the A
   // through G entries of the SkColorSpaceTransferFn structure in alphabetical
   // order.
   float custom_transfer_params_[7] = {0, 0, 0, 0, 0, 0, 0};
 
   // This is used to look up the ICCProfile from which this ColorSpace was
   // created, if possible.
   uint64_t icc_profile_id_ = 0;
   sk_sp<SkColorSpace> icc_profile_sk_color_space_;
 
   friend class ICCProfile;
   friend class ColorTransform;
   friend class ColorTransformInternal;
   friend class ColorSpaceWin;
   friend struct IPC::ParamTraits<gfx::ColorSpace>;
   FRIEND_TEST_ALL_PREFIXES(SimpleColorSpace, GetColorSpace);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_COLOR_SPACE_H_