components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java - Issue 2697833003: [Cronet] Add isDone() check in CronetBidirectionalStream#onWritevCompleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

Issue 2697833003: [Cronet] Add isDone() check in CronetBidirectionalStream#onWritevCompleted (Closed)

Patch Set: re-enable check Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

index de0a2e71826931fef9a7ddbbb1eff6cb1a6fbbbd..624c7d15ea40622e9e57c7981868b61f5fa56e95 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

@@ -546,6 +546,7 @@ public class CronetBidirectionalStream extends ExperimentalBidirectionalStream {

assert byteBuffers.length == initialPositions.length;

assert byteBuffers.length == initialLimits.length;

synchronized (mNativeStreamLock) {

+ if (isDoneLocked()) return;

mWriteState = State.WAITING_FOR_FLUSH;

// Flush if there is anything in the flush queue mFlushData.

if (!mFlushData.isEmpty()) {