[Cronet] Add isDone() check in CronetBidirectionalStream#onWritevCompleted

components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import static org.chromium.base.CollectionUtil.newHashSet;
 
 import android.os.ConditionVariable;
 import android.support.test.filters.SmallTest;
@@ skipping 382 matching lines @@
         assertEquals("123456", callback.mResponseAsString);
         assertEquals("bar", callback.mResponseInfo.getAllHeaders().get("echo-foo").get(0));
         assertEquals("", callback.mResponseInfo.getAllHeaders().get("echo-empty").get(0));
         assertEquals(
                 "zebra", callback.mResponseInfo.getAllHeaders().get("echo-content-type").get(0));
     }
 
     @SmallTest
     @Feature({"Cronet"})
     @OnlyRunNativeCronet
+    // Regression test for crbug.com/692168. This test is racy, but it should catch the regression
+    // sometimes.
+    public void testCancelWhileWriteDataPending() throws Exception {
+        String url = Http2TestServer.getEchoStreamUrl();
+        TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback() {
+            // Number of onWriteCompleted callbacks that have been invoked.
+            private int mNumWriteCompleted = 0;
+            @Override
+            public void onWriteCompleted(BidirectionalStream stream, UrlResponseInfo info,
+                    ByteBuffer buffer, boolean endOfStream) {
+                mNumWriteCompleted++;
+                super.onWriteCompleted(stream, info, buffer, endOfStream);
+                assertTrue(mNumWriteCompleted <= 2);
+                // Cancel in the second write callback to get a better chance of catching the race.
+                if (mNumWriteCompleted == 2) {
+                    stream.cancel();
+                }
+            }
+        };
+        byte[] dummyString = "dummy".getBytes();
+        callback.addWriteData(dummyString, true);
+        callback.addWriteData(dummyString, false);
+        callback.addWriteData(dummyString, true);
+        callback.addWriteData(dummyString, false);
+        callback.addWriteData(dummyString, false);
+        callback.addWriteData(dummyString, false);
+        callback.addWriteData(dummyString, true);
+        callback.addWriteData(dummyString, false);
+        callback.addWriteData(dummyString, true);
+        callback.addWriteData(dummyString, false);
+        CronetBidirectionalStream stream =
+                (CronetBidirectionalStream) mTestFramework.mCronetEngine
+                        .newBidirectionalStreamBuilder(url, callback, callback.getExecutor())
+                        .build();
+        callback.setAutoAdvance(false);
+        stream.start();
+        callback.waitForNextWriteStep(); // onStreamReady
+        // Write 1 and flush().
+        callback.startNextWrite(stream);
+        // Write 2, 3 and flush(). 2 and 3 are in the flush queue.
+        callback.startNextWrite(stream);
+        callback.setAutoAdvance(true);
+        callback.blockForDone();
+        assertTrue(callback.mOnCanceledCalled);
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunNativeCronet
     public void testSimpleGetWithFlush() throws Exception {
         // TODO(xunjieli): Use ParameterizedTest instead of the loop.
         for (int i = 0; i < 2; i++) {
             String url = Http2TestServer.getEchoStreamUrl();
             TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback() {
                 @Override
                 public void onStreamReady(BidirectionalStream stream) {
                     try {
                         // Attempt to write data for GET request.
                         stream.write(ByteBuffer.wrap("dummy".getBytes()), true);
@@ skipping 1037 matching lines @@
     private static String bufferContentsToString(ByteBuffer byteBuffer, int start, int end) {
         // Use a duplicate to avoid modifying byteBuffer.
         ByteBuffer duplicate = byteBuffer.duplicate();
         duplicate.position(start);
         duplicate.limit(end);
         byte[] contents = new byte[duplicate.remaining()];
         duplicate.get(contents);
         return new String(contents);
     }
 }