[Cronet] Add isDone() check in CronetBidirectionalStream#onWritevCompleted

components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.impl;
 
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
@@ skipping 396 matching lines @@
             for (ByteBuffer buffer : mFlushData) {
                 flushData.add(buffer.asReadOnlyBuffer());
             }
             return flushData;
         }
     }
 
     @Override
     public void cancel() {
         synchronized (mNativeStreamLock) {
-            if (isDoneLocked() || mReadState == State.NOT_STARTED) {
+            if (isDoneLocked()) {
                 return;
             }
             mReadState = mWriteState = State.CANCELED;
             destroyNativeStreamLocked(true);
         }
     }
 
     @Override
     public boolean isDone() {
         synchronized (mNativeStreamLock) {
             return isDoneLocked();
         }
     }
 
     @GuardedBy("mNativeStreamLock")
     private boolean isDoneLocked() {
-        return mReadState != State.NOT_STARTED && mNativeStream == 0;
+        return mNativeStream == 0;
     }
 
     /*
      * Runs an onSucceeded callback if both Read and Write sides are closed.
      */
     private void maybeOnSucceededOnExecutor() {
         synchronized (mNativeStreamLock) {
             if (isDoneLocked()) {
                 return;
             }
@@ skipping 94 matching lines @@
         postTaskToExecutor(mOnReadCompletedTask);
     }
 
     @SuppressWarnings("unused")
     @CalledByNative
     private void onWritevCompleted(final ByteBuffer[] byteBuffers, int[] initialPositions,
             int[] initialLimits, boolean endOfStream) {
         assert byteBuffers.length == initialPositions.length;
         assert byteBuffers.length == initialLimits.length;
         synchronized (mNativeStreamLock) {
             mWriteState = State.WAITING_FOR_FLUSH;

[mef, 2017/02/14 16:27:24]

I think we should add the check

                   if (isDoneLocked()) {
                        return;
                    }

here instead, because it is possible that adapter was destroyed while Writev was
running on network thread.

             // Flush if there is anything in the flush queue mFlushData.
             if (!mFlushData.isEmpty()) {
                 sendFlushDataLocked();
             }
         }
         for (int i = 0; i < byteBuffers.length; i++) {
             ByteBuffer buffer = byteBuffers[i];
             if (buffer.position() != initialPositions[i] || buffer.limit() != initialLimits[i]) {
                 failWithException(new CronetExceptionImpl(
                         "ByteBuffer modified externally during write", null));
@@ skipping 243 matching lines @@
     private native boolean nativeReadData(
             long nativePtr, ByteBuffer byteBuffer, int position, int limit);
 
     @NativeClassQualifiedName("CronetBidirectionalStreamAdapter")
     private native boolean nativeWritevData(long nativePtr, ByteBuffer[] buffers, int[] positions,
             int[] limits, boolean endOfStream);
 
     @NativeClassQualifiedName("CronetBidirectionalStreamAdapter")
     private native void nativeDestroy(long nativePtr, boolean sendOnCanceled);
 }