Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)
Patch Set: Address peter's review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 72d58a4c0da5ee86f24467f740fa240fff893433..bd6394c45a806f7a1e60986bd745b38e709ff457 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -107689,6 +107689,7 @@ from previous Chrome versions.
<int value="3" label="Registration not found"/>
<int value="4" label="Registration not found (no incognito push service)"/>
<int value="5" label="Unable to retrieve the public key"/>
+ <int value="6" label="Storage corrupt"/>
</enum>
<enum name="PushRegistrationStatus" type="int">
@@ -107710,13 +107711,15 @@ from previous Chrome versions.
<enum name="PushUnregistrationReason" type="int">
<int value="0" label="Unknown"/>
- <int value="1" label="JavaScript API"/>
+ <int value="1" label="unsubscribe() JavaScript API"/>
<int value="2" label="Permission revoked"/>
<int value="3" label="Incoming message app id was unknown"/>
<int value="4" label="Incoming message origin no longer has permission"/>
<int value="5" label="Incoming message Service Worker not found"/>
<int value="6" label="GCM Store reset due to corruption"/>
<int value="7" label="Service Worker unregistered"/>
+ <int value="8" label="subscribe() storage corrupt"/>
+ <int value="9" label="getSubscription() storage corrupt"/>
</enum>
<enum name="PushUnregistrationStatus" type="int">

Powered by Google App Engine
This is Rietveld 408576698