Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)
Patch Set: Comment out PUSH_GETREGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h
index 5dd7aaaa5f84f3d9c47c1c7ef05da42da95c6ded..98b8ea9b2de508212b8464bdd04363154811bbb8 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.h
+++ b/content/browser/push_messaging/push_messaging_message_filter.h
@@ -59,12 +59,6 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
const std::vector<std::string>& push_registration_id,
ServiceWorkerStatusCode service_worker_status);
- void DidGetEncryptionKeys(const RegisterData& data,
- const std::string& push_registration_id,
- bool success,
- const std::vector<uint8_t>& p256dh,
- const std::vector<uint8_t>& auth);
-
void DidGetSenderIdFromStorage(const RegisterData& data,
const std::vector<std::string>& sender_id,
ServiceWorkerStatusCode service_worker_status);
@@ -118,13 +112,6 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
const std::vector<std::string>& push_subscription_id_and_sender_info,
ServiceWorkerStatusCode service_worker_status);
- void DidGetSubscriptionKeys(int request_id,
- const GURL& endpoint,
- const std::string& sender_info,
- bool success,
- const std::vector<uint8_t>& p256dh,
- const std::vector<uint8_t>& auth);
-
// GetPermission methods on IO thread ----------------------------------------
void OnGetPermissionStatus(int request_id,
@@ -145,6 +132,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
// Inner core of this message filter which lives on the UI thread.
std::unique_ptr<Core, BrowserThread::DeleteOnUIThread> ui_core_;
+ base::WeakPtr<Core> ui_core_weak_ptr_;
scoped_refptr<ServiceWorkerContextWrapper> service_worker_context_;

Powered by Google App Engine
This is Rietveld 408576698