components/gcm_driver/gcm_client_impl.h - Issue 2697793004: Push API: Validate storage before returning cached subscriptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client_impl.h

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)

Patch Set: Comment out PUSH_GETREGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/gcm_client_impl.h

diff --git a/components/gcm_driver/gcm_client_impl.h b/components/gcm_driver/gcm_client_impl.h

index 9e102154b86b20e1cbe8c7ac5d81432a36087b1f..f546cfb788900fcd525574ac0cbdfb267c5f1408 100644

--- a/components/gcm_driver/gcm_client_impl.h

+++ b/components/gcm_driver/gcm_client_impl.h

@@ -118,6 +118,9 @@ class GCMClientImpl

void Register(const linked_ptr<RegistrationInfo>& registration_info) override;

void Unregister(

const linked_ptr<RegistrationInfo>& registration_info) override;

+ bool ValidateRegistration(

Peter Beverloo 2017/03/20 23:50:13 micro nit: ordering (one line up)

johnme 2017/03/30 18:36:38 Done.

+ const linked_ptr<RegistrationInfo>& registration_info,

+ const std::string& registration_id) override;

void Send(const std::string& app_id,

const std::string& receiver_id,

const OutgoingMessage& message) override;