Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: media/mojo/interfaces/audio_output.mojom

Issue 2697793002: Add mojo interface+impl for audio stream control. (Closed)
Patch Set: Move to media Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module media.mojom; 5 module media.mojom;
6 6
7 import "media/mojo/interfaces/audio_parameters.mojom"; 7 import "media/mojo/interfaces/audio_parameters.mojom";
8 import "media/mojo/interfaces/media_types.mojom";
9 import "url/mojo/origin.mojom";
8 10
9 // This interface handles audio output stream operations. 11 // On error, the message pipe is closed.
10 // It allows to close a stream. 12 // To close the stream, just close the message pipe.
11 // TODO(rchtara): Add methods that allow the interaction with audio output 13 interface AudioOutput {
DaleCurtis 2017/02/21 18:18:32 Can you fill these comments out now? I.e., high le
Max Morin 2017/02/22 10:08:43 Added comments, changed to Initialize.
DaleCurtis 2017/02/22 18:13:37 After I wrote this, I got this feedback on my own
12 // streams: Play, Pause and SetVolume to this interface. 14 Start(media.mojom.AudioParameters params) =>
13 // See crbug.com/606707 for more details. 15 (handle<shared_buffer> shared_buffer,
14 interface AudioOutputStream { 16 handle socket_descriptor);
15 Close(); 17 Play();
18 Pause();
19 // Volume is in the range [0, 1].
20 SetVolume(double volume);
16 }; 21 };
17
18 // This interface manages audio output streams.
19 // It allows to create an AudioOutputStream.
20 // TODO(rchtara): Add a method to request device authorization to this
21 // interface.
22 // See crbug.com/606707 for more details.
23 interface AudioOutput {
24 // TODO(rchtara): Remove |stream_id| from AudioOutput::CreateStream when all
25 // the stream operations are mojofied.
26 CreateStream(
27 int32 stream_id,
28 AudioParameters params) =>
29 (int32 stream_id,
30 AudioOutputStream? stream,
31 handle<shared_buffer>? shared_buffer,
32 handle? socket_descriptor);
33 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698