Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html

Issue 2697743002: Reduce strictness of length animation DCHECK (Closed)
Patch Set: _dcheckLengthApply Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html
diff --git a/third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html b/third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html
new file mode 100644
index 0000000000000000000000000000000000000000..4e74f0d495390fa7f592e6c757a377e9c23315a3
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html
@@ -0,0 +1,9 @@
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<div id="target"></div>
+<script>
+test(() => {
+ target.animate({margin: ['1px', '0%']}, {iterationStart: 0.5, fill: 'forwards'});
+ assert_equals(getComputedStyle(target).margin, '0.5px');
+}, "Don't crash when animating length properties to 0%");
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698