third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp - Issue 2697743002: Reduce strictness of length animation DCHECK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

Issue 2697743002: Reduce strictness of length animation DCHECK (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html ('K') | « third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

index 7d79676668c367e86a1bb09d6768b98b6ca103bd..ebb2ac6f80ccccd121ae1c22fd4eb73229c5ac0e 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

@@ -158,7 +158,7 @@ void CSSLengthInterpolationType::applyStandardPropertyValue(

StyleBuilder::applyProperty(cssProperty(), state,

*CSSValue::create(length, zoom));

DCHECK(LengthPropertyFunctions::getLength(cssProperty(), style, after));

- DCHECK_EQ(before.type(), after.type());

+ DCHECK_EQ(before.isSpecified(), after.isSpecified());

suzyh_UTC10 (ex-contributor) 2017/02/14 04:38:51 I'm not very familiar with LengthType. I think thi

alancutter (OOO until 2018) 2017/02/14 04:46:12 Good point, added type check back for that case.

if (before.isSpecified()) {

const float kSlack = 0.1;

float delta =