third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html - Issue 2697743002: Reduce strictness of length animation DCHECK

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/animations/length-zero-percent-crash.html

Issue 2697743002: Reduce strictness of length animation DCHECK (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script src="../resources/testharness.js"></script>

	2 <script src="../resources/testharnessreport.js"></script>

	3 <div id="target"></div>

	4 <script>

	5 test(() => {

	6 target.animate({margin: ['1px', '0%']}, {iterationStart: 0.5, fill: 'forwards' });

	7 assert_equals(getComputedStyle(target).margin, '0.5px');

	8 }, 'Don\'t crash when animating length properties to 0%');
	suzyh_UTC10 (ex-contributor) 2017/02/14 04:38:51 Nit: I prefer "Don't ..." to 'Don\'t ...', unless Nit: I prefer "Don't ..." to 'Don\'t ...', unless there's a style guide rule I've forgotten. alancutter (OOO until 2018) 2017/02/14 04:46:12 Done. Show quoted text On 2017/02/14 at 04:38:51, suzyh wrote: > Nit: I prefer "Don't ..." to 'Don\'t ...', unless there's a style guide rule I've forgotten. Done.
	9 </script>

OLD	NEW