Refactor decode-audio-data-basic.html to use testharness

third_party/WebKit/LayoutTests/webaudio/resources/audit.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileOverview  WebAudio layout test utility library. Built around W3C's
  *                testharness.js. Includes asynchronous test task manager,
  *                assertion utilities.
  * @dependency    testharness.js
@@ skipping 303 matching lines @@
       } catch (error) {
         didThrowCorrectly = true;
         failDetail = '${actual} incorrectly threw ' + error.name + ': "'
             + error.message + '".';
       }
 
       return this._assert(!didThrowCorrectly, passDetail, failDetail);
     }
 
     /**
-     * Check if |actual| promise is resolved correctly.
+     * Check if |actual| promise is resolved correctly. Note that the returned
+     * result from promise object will be passed to the following then()
+     * function.
      *
      * @example
-     *   should('My promise', promise).beResolve().then(nextStuff);
+     *   should('My promise', promise).beResolve().then((result) => {
+     *     console.log(result);
+     *   });
      *
      * @result
      *   "PASS   My promise resolved correctly."
      *   "FAIL X My promise rejected *INCORRECTLY* with _ERROR_."
      */
     beResolved () {
-      return this._actual.then(function () {
-          this._assert(true, '${actual} resolved correctly.', null);
-        }.bind(this), function (error) {
-          this._assert(false, null,
-              '${actual} rejected incorrectly with ' + error + '.');
-        }.bind(this));
+      return this._actual.then(
+          function(result) {
+            this._assert(true, '${actual} resolved correctly.', null);
+            return result;
+          }.bind(this),
+          function(error) {
+            this._assert(
+                false, null,
+                '${actual} rejected incorrectly with ' + error + '.');
+          }.bind(this));
     }
 
     /**
      * Check if |actual| promise is rejected correctly.
      *
      * @example
      *   should('My promise', promise).beRejected().then(nextStuff);
      *
      * @result
      *   "PASS   My promise rejected correctly (with _ERROR_)."
@@ skipping 738 matching lines @@
         return;
       }
 
       // Start the first task.
       this._currentTaskIndex = 0;
       this._runNextTask();
     }
 
   }
 
+  /**
+   * Load file from a given URL and pass ArrayBuffer to the following promise.
+   * @param  {String} fileUrl file URL.
+   * @return {Promise}
+   *
+   * @example
+   *   Audit.loadFileFromUrl('resources/my-sound.ogg').then((response) => {
+   *       audioContext.decodeAudioData(response).then((audioBuffer) => {
+   *           // Do something with AudioBuffer.
+   *       });
+   *   });
+   */
+  function loadFileFromUrl(fileUrl) {
+    return new Promise((resolve, reject) => {
+      let xhr = new XMLHttpRequest();
+      xhr.open('GET', fileUrl);
+      xhr.responseType = 'arraybuffer';
+
+      xhr.onload = () => {
+        if (xhr.status === 200) {
+          resolve(xhr.response);
+        } else {
+          let errorMessage = 'loadFile: Request failed when loading ' +
+              fileUrl + '. (' + xhr.statusText + ')';
+          if (reject) {
+            reject(errorMessage);
+          } else {
+            new Error(errorMessage);
+          }
+        }
+      };
+
+      xhr.onerror = (event) => {
+        let errorMessage =
+            'loadFile: Network failure when loading ' + fileUrl + '.';

[Raymond Toy, 2017/02/15 23:15:53]

Is this the only way for xhr to fail? (Network failure)

[hongchan, 2017/02/15 23:40:36]

Nope. See l.1130. If the request status is not 200, it is considered an invalid
response.

Also this diff should have not been included here. I think these are unwanted
artifacts of clang-format.

+        if (reject) {
+          reject(errorMessage);
+        } else {
+          new Error(errorMessage);
+        }
+      };
+
+      xhr.send();
+    });
+  }
 
   /**
    * @class Audit
    * @description A WebAudio layout test task manager.
    * @example
    *   let audit = Audit.createTaskRunner();
    *   audit.define('first-task', function (task, should) {
    *     task.describe('the first task');
    *     should(someValue).beEqualTo(someValue);
    *     task.done();
    *   });
    *   audit.run();
    */
   return {
 
     /**
      * Creates an instance of Audit task runner.
      * @param {Object}  options                     Options for task runner.
      * @param {Boolean} options.requireResultFile   True if the test suite
      *                                              requires explicit text
      *                                              comparison with the expected
      *                                              result file.
      */
-    createTaskRunner: function (options) {
+    createTaskRunner: function(options) {
       if (options && options.requireResultFile == true) {
         _logError('this test requires the explicit comparison with the '
             + 'expected result when it runs with run-webkit-tests.');
       }
 
       return new TaskRunner();
-    }
+    },
+
+    /**
+     * Load file from a given URL and pass ArrayBuffer to the following promise.
+     * See |loadFileFromUrl| method for the detail.
+     */
+    loadFileFromUrl: loadFileFromUrl
 
   };
 
 })();