Refactor decode-audio-data-basic.html to use testharness

third_party/WebKit/LayoutTests/webaudio/resources/audit.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileOverview  WebAudio layout test utility library. Built around W3C's
  *                testharness.js. Includes asynchronous test task manager,
  *                assertion utilities.
  * @dependency    testharness.js
@@ skipping 313 matching lines @@
      * Check if |actual| promise is resolved correctly.
      *
      * @example
      *   should('My promise', promise).beResolve().then(nextStuff);
      *
      * @result
      *   "PASS   My promise resolved correctly."
      *   "FAIL X My promise rejected *INCORRECTLY* with _ERROR_."
      */
     beResolved () {
-      return this._actual.then(function () {
+      return this._actual.then(function (result) {

[Raymond Toy, 2017/02/14 22:47:56]

This needs to be documented somehow.

[hongchan, 2017/02/14 22:54:39]

Done.

           this._assert(true, '${actual} resolved correctly.', null);
+          return result;
         }.bind(this), function (error) {
           this._assert(false, null,
               '${actual} rejected incorrectly with ' + error + '.');
         }.bind(this));
     }
 
     /**
      * Check if |actual| promise is rejected correctly.
      *
      * @example
@@ skipping 742 matching lines @@
         return;
       }
 
       // Start the first task.
       this._currentTaskIndex = 0;
       this._runNextTask();
     }
 
   }
 
+  /**
+   * Load file from a given URL and pass ArrayBuffer to the following promise.
+   * @param  {String} fileUrl file URL.
+   * @return {Promise}
+   *
+   * @example
+   *   Audit.loadFile('resources/my-sound.ogg').then((response) => {
+   *       audioContext.decodeAudioData(response).then((audioBuffer) => {
+   *           // Do something with AudioBuffer.
+   *       });
+   *   });
+   */
+  function loadFileAtUrl (fileUrl) {

[Raymond Toy, 2017/02/14 22:47:56]

Documentation says loadFile, but the function is loadFileAtUrl.  I think I
actually prefer loadFileFromUrl.

Would this support data uri's?  If not, that's ok.

[hongchan, 2017/02/14 22:54:39]

Done.

A good question. I have no idea for now.

+    return new Promise((resolve, reject) => {
+      let xhr = new XMLHttpRequest();
+      xhr.open('GET', fileUrl);
+      xhr.responseType = 'arraybuffer';
+
+      xhr.onload = () => {
+        if (xhr.status === 200) {
+          resolve(xhr.response);
+        } else {
+          let errorMessage = 'loadFile: Request failed when loading ' +
+                             fileUrl + '. (' + xhr.statusText + ')';
+          if (reject) {
+            reject(errorMessage);
+          } else {
+            new Error(errorMessage);
+          }
+        }
+      };
+
+      xhr.onerror = (event) => {
+        let errorMessage = 'loadFile: Network failure when loading ' +
+                           fileUrl + '.';
+        if (reject) {
+          reject(errorMessage);
+        } else {
+          new Error(errorMessage);
+        }
+      };
+
+      xhr.send();
+    });
+  }
 
   /**
    * @class Audit
    * @description A WebAudio layout test task manager.
    * @example
    *   let audit = Audit.createTaskRunner();
    *   audit.define('first-task', function (task, should) {
    *     task.describe('the first task');
    *     should(someValue).beEqualTo(someValue);
    *     task.done();
@@ skipping 10 matching lines @@
      *                                              comparison with the expected
      *                                              result file.
      */
     createTaskRunner: function (options) {
       if (options && options.requireResultFile == true) {
         _logError('this test requires the explicit comparison with the '
             + 'expected result when it runs with run-webkit-tests.');
       }
 
       return new TaskRunner();
-    }
+    },
+
+    /**
+     * Load file from a given URL and pass ArrayBuffer to the following promise.
+     * See |loadFileAtUrl| method for the detail.
+     */
+    loadFileAtUrl: loadFileAtUrl
 
   };
 
 })();