Fix credentials initialization.

Fix credentials initialization.

BUG=342884
TEST=manual
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267935

[achuithb, 2014-05-02 21:16:25]

Please review, Tim

[Tim Song, 2014-05-02 21:26:23]

https://codereview.chromium.org/269773004/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py (right):

https://codereview.chromium.org/269773004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py:81: credentials
= [None, None]
You can use a named tuple or even a regular tuple here instead.

https://codereview.chromium.org/269773004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py:84: credentials
= f.read().rstrip().split(':')
You could write

username, password = f.read.rstrip().split(':')

to explicitly get the credentials, and force an exception here rather than down
the road if the file isn't properly formatted.

[achuithb, 2014-05-02 21:52:20]

PTAL

https://codereview.chromium.org/269773004/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py (right):

https://codereview.chromium.org/269773004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py:81: credentials
= [None, None]
On 2014/05/02 21:26:23, Tim Song wrote:
> You can use a named tuple or even a regular tuple here instead.

Done.

https://codereview.chromium.org/269773004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py:84: credentials
= f.read().rstrip().split(':')
On 2014/05/02 21:26:23, Tim Song wrote:
> You could write
> 
> username, password = f.read.rstrip().split(':')
> 
> to explicitly get the credentials, and force an exception here rather than
down
> the road if the file isn't properly formatted.

Done.

[achuithb, 2014-05-02 21:53:01]

Err, sec, wrong CL

[achuithb, 2014-05-02 21:54:39]

PTAL

[Tim Song, 2014-05-02 21:55:12]

lgtm

[achuithb, 2014-05-02 21:55:35]

On 2014/05/02 21:55:12, Tim Song wrote:
> lgtm

ty

[achuithb, 2014-05-02 21:55:38]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:55:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achuith@chromium.org/269773004/20001

[commit-bot: I haz the power, 2014-05-02 21:57:09]

Change committed as 267935